Updated developer on-call #26795
Updated developer on-call #26795
Conversation
Added a small bash script to query for community PRs open.
|
The output looks something like this: 
|
There was a problem hiding this comment.
Thanks for putting this together! I was going to suggest putting it in a new /tools/oncall directory, but saw that we already have one, and @lucasmrod wrote a similar script: https://github.com/fleetdm/fleet/tree/main/tools/oncall.
If yours is materially different, please add it to that directory and update the README with instructions.
If not, I think this is an example of us not doing a good job consolidating and centralizing our developer tools and documentation. Would you please revise this PR to include a link to the /tools/oncall directory?
handbook/company/product-groups.md
Outdated
| days_ago=$(( (current_epoch - created_at_epoch) / 86400 )) | ||
| printf "%s#@#%s#@#%s\n" "$url" "$user created $days_ago days ago" "$title" | ||
| done | column -s '#@#' -t | ||
| ``` |
There was a problem hiding this comment.
I would move this whole script into tools/oncall and then reference it here.
Feel free to remove the ones already in tools/oncall/ if this script replaces them (they haven't been used/udpated for a while).
|
Well that unfortunate, love doing double work. I did not know that we already had a script to this. I can tomb stone this for the |
Fix the existing sh script to pull more a larger size of open prs. There does not seem to be a way to paginate, only a way to set the limit, so we'll set it to a large enough number to scan all prs.
| @@ -50,7 +50,7 @@ prs() { | |||
| members="$(curl -s -u "${username}:${token}" https://api.github.com/orgs/fleetdm/members?per_page=100 | jq -r 'map(.login)' | jq '. += ["app/dependabot"]')" | |||
|
|
|||
| # defaults to listing open prs | |||
| gh pr list --repo fleetdm/fleet --json id,title,author,url,createdAt | | |||
| gh pr list --limit 1000 --repo fleetdm/fleet --json id,title,author,url,createdAt | | |||
There was a problem hiding this comment.
Ah good catch otherwise defaults to 30.
Updated docs to point developers to bash script to pull open community issues and prs.
Added greater limit to existing pr fetch call.