Add experimental software title name update endpoint for titles with a bundle ID #26938
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #26938 +/- ##
==========================================
- Coverage 64.02% 64.01% -0.01%
==========================================
Files 1701 1701
Lines 162252 162279 +27
Branches 4272 4272
==========================================
+ Hits 103874 103889 +15
- Misses 50319 50329 +10
- Partials 8059 8061 +2
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
jahzielv
reviewed
Mar 7, 2025
|
@jahzielv Just titles. Titles to software are 1:M and the first piece of software (uploaded or ingested) with a given bundle ID "wins" for determining title name, which sometimes results in the wrong name even when subsequent ingested software has the correct name. This allows admins to manually fix these cases. |
jahzielv
previously approved these changes
Mar 7, 2025
rachaelshaw
reviewed
Mar 7, 2025
|
|
||
| ```json | ||
| { | ||
| "name": "2 Chrome 2 Furious.app" |
rachaelshaw
reviewed
Mar 7, 2025
rachaelshaw
previously approved these changes
Mar 7, 2025
Co-authored-by: Rachael Shaw <[email protected]>
jahzielv
approved these changes
Mar 7, 2025
rachaelshaw
approved these changes
Mar 7, 2025
iansltx
added a commit
that referenced
this pull request
Mar 7, 2025
…a bundle ID (#26938) For #26933. # Checklist for submitter If some of the following don't apply, delete the relevant line. <!-- Note that API documentation changes are now addressed by the product design team. --> - [x] Changes file added for user-visible changes in `changes/`, `orbit/changes/` or `ee/fleetd-chrome/changes`. See [Changes files](https://github.com/fleetdm/fleet/blob/main/docs/Contributing/Committing-Changes.md#changes-files) for more information. - [x] Input data is properly validated, `SELECT *` is avoided, SQL injection is prevented (using placeholders for values in statements) - [x] Added/updated automated tests - [x] A detailed QA plan exists on the associated ticket (if it isn't there, work with the product group's QA engineer to add it) - [x] Manual QA for all new/changed functionality --------- Co-authored-by: Rachael Shaw <[email protected]>
iansltx
added a commit
that referenced
this pull request
Mar 7, 2025
…a bundle ID (#26938) For #26933. # Checklist for submitter If some of the following don't apply, delete the relevant line. <!-- Note that API documentation changes are now addressed by the product design team. --> - [x] Changes file added for user-visible changes in `changes/`, `orbit/changes/` or `ee/fleetd-chrome/changes`. See [Changes files](https://github.com/fleetdm/fleet/blob/main/docs/Contributing/Committing-Changes.md#changes-files) for more information. - [x] Input data is properly validated, `SELECT *` is avoided, SQL injection is prevented (using placeholders for values in statements) - [x] Added/updated automated tests - [x] A detailed QA plan exists on the associated ticket (if it isn't there, work with the product group's QA engineer to add it) - [x] Manual QA for all new/changed functionality --------- Co-authored-by: Rachael Shaw <[email protected]>
iansltx
added a commit
that referenced
this pull request
Mar 7, 2025
… titles with a bundle ID (#26959) Merged into `main` in #26938. Co-authored-by: Rachael Shaw <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For #26933.
Checklist for submitter
If some of the following don't apply, delete the relevant line.
changes/,orbit/changes/oree/fleetd-chrome/changes.See Changes files for more information.
SELECT *is avoided, SQL injection is prevented (using placeholders for values in statements)