Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Cursor based pagination support #17

Merged
merged 40 commits into from
Feb 15, 2024
Merged

Cursor based pagination support #17

merged 40 commits into from
Feb 15, 2024

Conversation

jmmizerany
Copy link
Collaborator

  • First initial PR for our singer tap
  • Switch to using cursor based pagination
  • Match schemas 1:1 to the API

@jmmizerany
add in replcation keys
4c8b35f
@jmmizerany
refactor client to handle incremental
0e165b7
@jmmizerany
finalize incremental loads
e5237aa
@jmmizerany
incremental replicaton and new streams
f245198
@jmmizerany
add release drafter for versioning
ece7fa8
@jmmizerany
add better tests, bump python versions down
5a49fa6
@jmmizerany
add env variables
133d335
@jmmizerany
fix environment variables in workflow
97cb84f
@jmmizerany
force run
7f52bc9
@jmmizerany
fix workflow file
0531d91
@jmmizerany
change environments to global scope
d18b155
@jmmizerany
switch urls, change schemas
bad3fc7
@jmmizerany
remove
d5951e0
@jmmizerany
add configs to switch between API versions, remove replication keys
36b2caa
@jmmizerany
swtich has_more to version based API
176ea4d
@jmmizerany
move json_paths to streams
9d02631
@jmmizerany
make api url changeable
4d8e8e3
@jmmizerany
switch back
32f6124
@jmmizerany
switch back
885086b
@jmmizerany
fix schema
88ea3ef
@jmmizerany
fix schema
1513906
@jmmizerany
refresh all stream catalog
088ea4b
@jmmizerany
remove catalog
7b52519
@jmmizerany
fix schema, patch pagination
eb7ed57
@jmmizerany
switch client name
1b94e47
@jmmizerany
change client name
23ec117
@jmmizerany
update schemas
7d84270
@jmmizerany
remove .DS_Store
da87d10
@jmmizerany
update .gitignore
c6bec41
@jmmizerany
update schemas, service_entries and submitted_inspection_forms
5cc534a
@jmmizerany jmmizerany added the enhancement New feature or request label Feb 12, 2024
jchen-fleetio
jchen-fleetio suggested changes Feb 12, 2024
View reviewed changes
Copy link

@jchen-fleetio jchen-fleetio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Two small comments added to specific files.

Additionally, I think we need to update the readme file to include links to fleetio.com in the description as well as our API docs.

meltano.yml Outdated Show resolved Hide resolved
jchen-fleetio
jchen-fleetio approved these changes Feb 15, 2024
View reviewed changes
Copy link

@jchen-fleetio jchen-fleetio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jmmizerany jmmizerany merged commit a866832 into main Feb 15, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jchen-fleetio jchen-fleetio jchen-fleetio approved these changes

Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jmmizerany @jchen-fleetio