-
Notifications
You must be signed in to change notification settings - Fork 457
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added ImageViewer Control to display full screen Image with Zoom, Pan & paging #2248
base: main
Are you sure you want to change the base?
Conversation
Merge changes
Merge changes
…into ImageViewerControl
Sorry for the delay with reply... I honestly believe widgets like ImageViewer should be implemented as "out-of-band" (OOB) Flet controls in separate libraries, that user can optionally add to the app (via We will create guidelines (there is an item on roadmap) on how to create a Python part (Python adapter) for a custom control and how to create and publish Flutter/Dart part of the control. I think some of the existing or future Flet "core" controls could be implemented as optional "extensions", e.g. audioplayer, video, webview - they add a certain weight into the resulting app, but not all users need them. |
I'm leaving this PR open as a possible candidate for testing OOB control extensions. |
Aw, but it seemed like a simple, useful, general use UI function that so many apps use when you click on an image. I've used a full-screen Image Zoom feature in every Flutter app I've done, seemed like it should be a core feature, but it is up to you. |
🤓 OK, could you please update this PR from |
Looks like merging gone wrong - CI is failing: https://ci.appveyor.com/project/flet-dev/flet/builds/48927108/job/bb574ivys2ifw3d3#L145 |
Thanks Feodor, I fixed those minor issues and got the changes merged. Hopefully it's all good now, let me know if there's anything else I can do. Appreciate your hard work, trying to make it as easy as possible for ya.. |
Merge changes
Wondering how this control is going... |
We need to make it in a separate package. |
Wondering how this control is going... |
I had it all done, even though the commit might need to be redone because main was updated where I couldn't update my PR. However Feodore then said it should be a separate package rather than core, which I have no idea how to do where I can still use it in my install without having to rebuild the package which I don't think would work for me in my Colab launcher. I had it done almost a year ago and it sat, but for me this was still a much needed feature that I've been living without... So I don't know what the next step would be if we have any hope of a standard full screen image viewer. |
A ImageViewer displays a full screen Image that allows Zoom, Pan, and paging through multipe images.
The image src can be a single image path String or a List of image strings to page through.
Example: