V3 #120
Open
V3 #120
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
shining-mind
reviewed
May 1, 2020
| context.data.request.command.toLowerCase() : ''; | ||
| const { relevanceProvider = getLevenshteinRelevance } = params; | ||
| return (context: Context) => { | ||
| const commandLower = context.data.request.command |
There was a problem hiding this comment.
This code duplicates at least 3 times, maybe it's better to implement function for this operation
shining-mind
reviewed
May 1, 2020
| @@ -90,11 +82,11 @@ export class ImagesApi implements IImagesApi { | |||
| const response = await fetch(url, { | |||
| method: method, | |||
| headers: { | |||
| 'Authorization': `OAuth ${this._oAuthToken}`, | |||
| Authorization: `OAuth ${this._oAuthToken}`, | |||
| 'Content-type': 'application/json', | |||
There was a problem hiding this comment.
It should be a 'Content-Type' header with capital T
shining-mind
reviewed
May 1, 2020
| @@ -0,0 +1,78 @@ | |||
| declare module 'alice-renderer' { | |||
There was a problem hiding this comment.
Declared Response interface is not-compatible with ApiResponseBody as a result tests won't work with the new reply.
I've tried to fix this issue in forked repo by declaring API as ambient module and importing API types here, but I can't find a good solution how to ship this types with NPM package. It seems that *.d.ts files added to dist folder won't be resolved by the typescript compiler if package is used as dependency.
shining-mind
reviewed
May 1, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.