refactor: command and query implementations

Signed-off-by: Lexus Drumgold <[email protected]>
flex-development · Nov 23, 2023 · 66f4746 · 66f4746
1 parent 0007cad
commit 66f4746
Show file tree

Hide file tree

Showing 78 changed files with 1,028 additions and 868 deletions.
diff --git a/.github/infrastructure.yml b/.github/infrastructure.yml
@@ -74,7 +74,7 @@ branches:
       strict: true
   - branch: release/*
     commit_signatures: true
-    conversation_resolution: null
+    conversation_resolution: false
     creations_blocked: true
     deletions: true
     deployments: null
@@ -91,7 +91,7 @@ branches:
     status_checks: null
 environments:
   - name: release
-    prevent_self_review: null
+    prevent_self_review: false
     reviewers: null
     wait_timer: null
 labels:

diff --git a/.schema.json b/.schema.json
@@ -71,7 +71,7 @@
             ]
           },
           "conversation_resolution": {
-            "description": "require all conversations on code to be resolved before a pull request can be merged into matching branches",
+            "description": "require all conversations on code to be resolved before a pull request can be merged",
             "type": [
               "boolean",
               "null"
@@ -129,7 +129,7 @@
             ]
           },
           "force_pushers": {
-            "description": "users, teams, and apps allowed to force push to matching branches",
+            "description": "users, teams, and apps allowed to force push",
             "oneOf": [
               {
                 "$ref": "#/$defs/BranchActors"
@@ -140,7 +140,7 @@
             ]
           },
           "force_pushes": {
-            "description": "allow force pushes to matching branches",
+            "description": "allow force pushes",
             "type": [
               "boolean",
               "null"
@@ -154,7 +154,7 @@
             ]
           },
           "linear_history": {
-            "description": "prevent merge commits from being pushed to matching branches",
+            "description": "prevent merge commits from being pushed",
             "type": [
               "boolean",
               "null"
@@ -231,7 +231,7 @@
             ]
           },
           "restrictions": {
-            "description": "users, teams, and apps allowed to push to matching branches",
+            "description": "users, teams, and apps allowed to push",
             "oneOf": [
               {
                 "$ref": "#/$defs/BranchActors"
@@ -353,7 +353,8 @@
             ]
           },
           "wait_timer": {
-            "description": "amount of time (in minutes) to delay a deployment",
+            "description": "amount of time (in minutes) to delay deployments",
+            "maximum": 43200,
             "minimum": 0,
             "type": [
               "integer",

diff --git a/.vscode/settings.json b/.vscode/settings.json
@@ -118,9 +118,9 @@
   "editor.bracketPairColorization.enabled": true,
   "editor.bracketPairColorization.independentColorPoolPerBracketType": true,
   "editor.codeActionsOnSave": {
-    "source.fixAll": true,
-    "source.fixAll.sortJSON": false,
-    "source.organizeImports": true
+    "source.fixAll": "always",
+    "source.fixAll.sortJSON": "never",
+    "source.organizeImports": "always"
   },
   "editor.defaultFormatter": "dprint.dprint",
   "editor.detectIndentation": false,

diff --git a/__fixtures__/api.github.json b/__fixtures__/api.github.json
@@ -554,200 +554,134 @@
         ],
         "nodes": [
           {
-            "color": "fbca04",
-            "description": "contains changes that require major version bump",
             "id": "LA_kwDOJGP3088AAAABN_3hjg",
             "name": "flag:breaking-change"
           },
           {
-            "color": "fbca04",
-            "description": "issue, pull request, or discussion already exists",
             "id": "LA_kwDOJGP3088AAAABN_3hlg",
             "name": "flag:duplicate"
           },
           {
-            "color": "fbca04",
-            "description": "discussion required before implementation",
             "id": "LA_kwDOJGP3088AAAABN_3hmw",
             "name": "flag:needs-discussion"
           },
           {
-            "color": "fbca04",
-            "description": "missing documentation or needs existing documentation update",
             "id": "LA_kwDOJGP3088AAAABN_3hoQ",
             "name": "flag:needs-docs"
           },
           {
-            "color": "fbca04",
-            "description": "code improvements required before being merged",
             "id": "LA_kwDOJGP3088AAAABN_3hqQ",
             "name": "flag:needs-refactor"
           },
           {
-            "color": "74cefc",
-            "description": "github action",
             "id": "LA_kwDOJGP3088AAAABOBL-2w",
             "name": "scope:action"
           },
           {
-            "color": "74cefc",
-            "description": "dependency updates",
             "id": "LA_kwDOJGP3088AAAABN_3ouw",
             "name": "scope:dependencies"
           },
           {
-            "color": "74cefc",
-            "description": "action release",
             "id": "LA_kwDOJGP3088AAAABN_3htg",
             "name": "scope:release"
           },
           {
-            "color": "74cefc",
-            "description": "testing",
             "id": "LA_kwDOJGP3088AAAABN_3oqw",
             "name": "scope:tests"
           },
           {
-            "color": "e7034b",
-            "description": "needs clarification or more information from author",
             "id": "LA_kwDOJGP3088AAAABN_3orw",
             "name": "status:awaiting-answers"
           },
           {
-            "color": "e7034b",
-            "description": "blocked by other work tracked in different issue",
             "id": "LA_kwDOJGP3088AAAABcUec2w",
             "name": "status:blocked"
           },
           {
-            "color": "e7034b",
-            "description": "bug report cannot be reproduced",
             "id": "LA_kwDOJGP3088AAAABcUec5A",
             "name": "status:cannot-reproduce"
           },
           {
-            "color": "e7034b",
-            "description": "fixed, but not released",
             "id": "LA_kwDOJGP3088AAAABcUec_Q",
             "name": "status:fixed"
           },
           {
-            "color": "e7034b",
-            "description": "extra attention is needed",
             "id": "LA_kwDOJGP3088AAAABcUedBw",
             "name": "status:help-wanted"
           },
           {
-            "color": "e7034b",
-            "description": "changes that won't be implemented",
             "id": "LA_kwDOJGP3088AAAABcUedCg",
             "name": "status:icebox"
           },
           {
-            "color": "e7034b",
-            "description": "no action to be taken or missing information",
             "id": "LA_kwDOJGP3088AAAABcUedDg",
             "name": "status:invalid"
           },
           {
-            "color": "e7034b",
-            "description": "merged, but not released",
             "id": "LA_kwDOJGP3088AAAABcUedFA",
             "name": "status:merged"
           },
           {
-            "color": "e7034b",
-            "description": "needs further assessment",
             "id": "LA_kwDOJGP3088AAAABcUedHQ",
             "name": "status:needs-triage"
           },
           {
-            "color": "e7034b",
-            "description": "merged and prereleased",
             "id": "LA_kwDOJGP3088AAAABcUedKQ",
             "name": "status:prereleased"
           },
           {
-            "color": "e7034b",
-            "description": "merged and released",
             "id": "LA_kwDOJGP3088AAAABcUedPA",
             "name": "status:released"
           },
           {
-            "color": "e7034b",
-            "description": "superseded by different issue, pull request, or discussion",
             "id": "LA_kwDOJGP3088AAAABcUedTA",
             "name": "status:stale"
           },
           {
-            "color": "e7034b",
-            "description": "bug confirmed",
             "id": "LA_kwDOJGP3088AAAABcUedYg",
             "name": "status:triaged"
           },
           {
-            "color": "e7034b",
-            "description": "work in progress",
             "id": "LA_kwDOJGP3088AAAABcUedbg",
             "name": "status:wip"
           },
           {
-            "color": "0052cc",
-            "description": "changes to the build system or external dependencies",
             "id": "LA_kwDOJGP3088AAAABcUeddQ",
             "name": "type:build"
           },
           {
-            "color": "0052cc",
-            "description": "housekeeping / changes that don't impact external users",
             "id": "LA_kwDOJGP3088AAAABcUeddw",
             "name": "type:chore"
           },
           {
-            "color": "0052cc",
-            "description": "ci/cd configuration",
             "id": "LA_kwDOJGP3088AAAABcUedeA",
             "name": "type:ci"
           },
           {
-            "color": "0052cc",
-            "description": "documentation improvements",
             "id": "LA_kwDOJGP3088AAAABcUedfA",
             "name": "type:docs"
           },
           {
-            "color": "0052cc",
-            "description": "new features and improvements",
             "id": "LA_kwDOJGP3088AAAABcUedgQ",
             "name": "type:feat"
           },
           {
-            "color": "0052cc",
-            "description": "bug reports and fixes",
             "id": "LA_kwDOJGP3088AAAABcUediQ",
             "name": "type:fix"
           },
           {
-            "color": "0052cc",
-            "description": "performance updates",
             "id": "LA_kwDOJGP3088AAAABcUedmg",
             "name": "type:perf"
           },
           {
-            "color": "0052cc",
-            "description": "questions",
             "id": "LA_kwDOJGP3088AAAABcUedpg",
             "name": "type:question"
           },
           {
-            "color": "0052cc",
-            "description": "code improvements",
             "id": "LA_kwDOJGP3088AAAABcUedqw",
             "name": "type:refactor"
           },
           {
-            "color": "0052cc",
-            "description": "project tasks",
             "id": "LA_kwDOJGP3088AAAABcUedrA",
             "name": "type:task"
           }