Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: vertical scrolling #621

Merged
merged 6 commits into from
Nov 25, 2023
Merged

fix: vertical scrolling #621

merged 6 commits into from
Nov 25, 2023

Conversation

SputNikPlop
Copy link
Contributor

@SputNikPlop SputNikPlop commented Oct 28, 2023 •
edited by flex3r
Loading

This changes horizontal scrolling to vertical scrolling. Closes #565

flex3r
flex3r requested changes Nov 1, 2023
View reviewed changes
Copy link
Owner

@flex3r flex3r left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't think we can or should just change all inputs to support multiple lines.
Please also include some screenshots for the input field that are going to change when they have multiple lines

gradle/libs.versions.toml Outdated Show resolved Hide resolved
app/src/main/res/layout/rm_host_bottomsheet.xml Outdated Show resolved Hide resolved
app/src/main/res/layout/add_channel_dialog.xml Outdated Show resolved Hide resolved
app/src/main/res/layout/edit_dialog.xml Outdated Show resolved Hide resolved
app/src/main/res/layout/emote_suggestion_item.xml Outdated Show resolved Hide resolved
app/src/main/res/layout/user_ignore_item.xml Outdated Show resolved Hide resolved
app/src/main/res/layout/user_highlight_item.xml Outdated Show resolved Hide resolved
app/src/main/res/layout/user_display_item.xml Outdated Show resolved Hide resolved
app/src/main/res/layout/user_display_item.xml Outdated Show resolved Hide resolved
app/src/main/res/layout/tts_ignore_list_item.xml Outdated Show resolved Hide resolved
@SputNikPlop
Copy link
Contributor Author

IMG-20231106-WA0000
I think this fix should work @flex3r let me know if this isn't quite what you want.

@SputNikPlop SputNikPlop requested a review from flex3r November 7, 2023 06:10
flex3r
flex3r requested changes Nov 9, 2023
View reviewed changes
Copy link
Owner

@flex3r flex3r left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks very good 👍
Just some minor stuff remaining

app/src/main/res/layout/main_fragment.xml Show resolved Hide resolved
app/src/main/res/layout/main_fragment.xml Outdated Show resolved Hide resolved
app/src/main/res/layout/main_fragment.xml Outdated Show resolved Hide resolved
@SputNikPlop SputNikPlop requested a review from flex3r November 25, 2023 17:01
@SputNikPlop
Copy link
Contributor Author

@flex3r Hopefully I got it right this time

flex3r
flex3r approved these changes Nov 25, 2023
View reviewed changes
Copy link
Owner

@flex3r flex3r left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good now, thanks for the contribution!

@flex3r flex3r enabled auto-merge (squash) November 25, 2023 17:25
@flex3r flex3r merged commit af23b6f into flex3r:develop Nov 25, 2023
4 checks passed
@SputNikPlop SputNikPlop deleted the scroll branch November 25, 2023 17:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@flex3r flex3r flex3r approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Suggestion: Horizontal chat input field scrolling
2 participants
@SputNikPlop @flex3r