shanoir-issue#2372: add endpoint to remove SR from viewer #2403
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
An issue is opened in the OHIF git page for this (missing Authorization header), this feature won't work until the issue is fixed: |
michaelkain
reviewed
Sep 10, 2024
shanoir-ng-datasets/src/main/java/org/shanoir/ng/dicom/web/DICOMWebApi.java
Outdated
Show resolved
Hide resolved
michaelkain
reviewed
Sep 10, 2024
shanoir-ng-datasets/src/main/java/org/shanoir/ng/dicom/web/DICOMWebApiController.java
Outdated
Show resolved
Hide resolved
michaelkain
reviewed
Sep 10, 2024
...-ng-datasets/src/main/java/org/shanoir/ng/dicom/web/StowRSMultipartRelatedRequestFilter.java
Outdated
Show resolved
Hide resolved
michaelkain
reviewed
Sep 10, 2024
shanoir-ng-datasets/src/main/java/org/shanoir/ng/dicom/web/DICOMWebApiController.java
Outdated
Show resolved
Hide resolved
michaelkain
reviewed
Sep 10, 2024
michaelkain
reviewed
Sep 13, 2024
|
Hi Pierre-Henri, |
…auvergne/shanoir-ng into shanoir-issue#2372
|
wait for MK |
|
OHIF has fixed the issue : OHIF/Viewers#4619 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
How to test:
Open DICOM in ohif viewer
Make a measurement
Open right-side panel
Click on "Create report":
At this point, a new dataset is visible in solr:
In the left-side panel, a new serie appears:
Click on the trash-bin icon, a pop-up appears, click 'yes' to delete the measurement:
The solr dataset is deleted.