Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

PD-1516 - return 400 when request payload is invalid json #18

Merged
merged 2 commits into from
Nov 25, 2024
Merged

PD-1516 - return 400 when request payload is invalid json #18

merged 2 commits into from
Nov 25, 2024

Conversation

etam-pro
Copy link
Contributor

Return 400 instead of 5xx when request json payload is invalid json

dorner
dorner requested changes Nov 25, 2024
View reviewed changes
Copy link
Member

@dorner dorner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@etam-pro can you fix the tests?

@etam-pro
Copy link
Contributor Author

My bad, fixed!

skawaguchi-flipp
skawaguchi-flipp approved these changes Nov 25, 2024
View reviewed changes
Copy link

@skawaguchi-flipp skawaguchi-flipp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@dorner dorner merged commit 90c1a15 into flipp-oss:main Nov 25, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@skawaguchi-flipp skawaguchi-flipp skawaguchi-flipp approved these changes

@dorner dorner dorner approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@etam-pro @dorner @skawaguchi-flipp