Replace ktorfit in remote controls (#905)

**Background**

Ktorfit updates sometimes causes difficulties to update it. This PR
replace ktorfit inside remote-controls module with raw ktor

**Changes**

- Remote ktorfit from remote-controls 

**Test plan**

- Launch app
- Open remote controls screen
- Follow full userflow of this feature

CHANGELOG.md

@@ -3,6 +3,7 @@
 # 1.7.2 - In Progress
 
 - [Refactor] Update to Kotlin 2.0
+- [Refactor] Replace Ktorfit with Ktor requests in remote-controls
 - [FIX] Distinct fap items by id in paging sources
 - [FIX] Battery level charge
 - [FIX] Button arrow tint

components/remote-controls/api-backend/build.gradle.kts

@@ -3,13 +3,11 @@ plugins {
     id("flipper.multiplatform-dependencies")
     id("kotlinx-serialization")
     id("flipper.anvil")
-    id("flipper.ktorfit-multiplatform")
 }
 
 android.namespace = "com.flipperdevices.remotecontrols.api.backend"
 
 commonDependencies {
-    implementation(libs.ktorfit.lib)
     implementation(libs.kotlin.coroutines)
     implementation(libs.kotlin.serialization.json)
     implementation(projects.components.core.di)

components/remote-controls/api-backend/src/commonMain/kotlin/com/flipperdevices/ifrmvp/api/infrared/InfraredBackendApi.kt

@@ -6,32 +6,15 @@ import com.flipperdevices.ifrmvp.backend.model.IfrFileContentResponse
 import com.flipperdevices.ifrmvp.backend.model.PagesLayoutBackendModel
 import com.flipperdevices.ifrmvp.backend.model.SignalRequestModel
 import com.flipperdevices.ifrmvp.backend.model.SignalResponseModel
-import de.jensklingenberg.ktorfit.http.Body
-import de.jensklingenberg.ktorfit.http.GET
-import de.jensklingenberg.ktorfit.http.POST
-import de.jensklingenberg.ktorfit.http.Query
 
 interface InfraredBackendApi {
-    @GET("categories")
     suspend fun getCategories(): CategoriesResponse
 
-    @GET("brands")
-    suspend fun getManufacturers(
-        @Query("category_id") categoryId: Long
-    ): BrandsResponse
+    suspend fun getManufacturers(categoryId: Long): BrandsResponse
 
-    @POST("signal")
-    suspend fun getSignal(
-        @Body request: SignalRequestModel
-    ): SignalResponseModel
+    suspend fun getSignal(request: SignalRequestModel): SignalResponseModel
 
-    @GET("key")
-    suspend fun getIfrFileContent(
-        @Query("ifr_file_id") ifrFileId: Long
-    ): IfrFileContentResponse
+    suspend fun getIfrFileContent(ifrFileId: Long): IfrFileContentResponse
 
-    @GET("ui")
-    suspend fun getUiFile(
-        @Query("ifr_file_id") ifrFileId: Long
-    ): PagesLayoutBackendModel
+    suspend fun getUiFile(ifrFileId: Long): PagesLayoutBackendModel
 }

components/remote-controls/api-backend/src/commonMain/kotlin/com/flipperdevices/ifrmvp/api/infrared/InfraredBackendApiImpl.kt

@@ -0,0 +1,69 @@
+package com.flipperdevices.ifrmvp.api.infrared
+
+import com.flipperdevices.core.di.AppGraph
+import com.flipperdevices.ifrmvp.api.infrared.model.InfraredHost
+import com.flipperdevices.ifrmvp.backend.model.BrandsResponse
+import com.flipperdevices.ifrmvp.backend.model.CategoriesResponse
+import com.flipperdevices.ifrmvp.backend.model.IfrFileContentResponse
+import com.flipperdevices.ifrmvp.backend.model.PagesLayoutBackendModel
+import com.flipperdevices.ifrmvp.backend.model.SignalRequestModel
+import com.flipperdevices.ifrmvp.backend.model.SignalResponseModel
+import com.squareup.anvil.annotations.ContributesBinding
+import io.ktor.client.HttpClient
+import io.ktor.client.call.body
+import io.ktor.client.request.get
+import io.ktor.client.request.parameter
+import io.ktor.client.request.post
+import io.ktor.client.request.setBody
+import io.ktor.client.request.url
+import io.ktor.http.ContentType
+import io.ktor.http.contentType
+import javax.inject.Inject
+
+@ContributesBinding(AppGraph::class, InfraredBackendApi::class)
+class InfraredBackendApiImpl(
+    private val httpClient: HttpClient,
+    private val host: InfraredHost = InfraredHost.DEV
+) : InfraredBackendApi {
+    @Inject
+    constructor(httpClient: HttpClient) : this(httpClient, InfraredHost.DEV)
+
+    override suspend fun getCategories(): CategoriesResponse {
+        return httpClient.get {
+            url("${host.url}/categories")
+            contentType(ContentType.Application.Json)
+        }.body()
+    }
+
+    override suspend fun getManufacturers(categoryId: Long): BrandsResponse {
+        return httpClient.get {
+            url("${host.url}/brands")
+            parameter("category_id", categoryId)
+            contentType(ContentType.Application.Json)
+        }.body()
+    }
+
+    override suspend fun getSignal(request: SignalRequestModel): SignalResponseModel {
+        return httpClient.post {
+            url("${host.url}/signal")
+            contentType(ContentType.Application.Json)
+            setBody(request)
+        }.body()
+    }
+
+    override suspend fun getIfrFileContent(ifrFileId: Long): IfrFileContentResponse {
+        return httpClient.get {
+            url("${host.url}/key")
+            parameter("ifr_file_id", ifrFileId)
+            contentType(ContentType.Application.Json)
+        }.body()
+    }
+
+    override suspend fun getUiFile(ifrFileId: Long): PagesLayoutBackendModel {
+        return httpClient.get {
+            url("${host.url}/ui")
+            parameter("ifr_file_id", ifrFileId)
+            contentType(ContentType.Application.Json)
+        }.body()
+    }
+}

components/remote-controls/api-backend/src/commonMain/kotlin/com/flipperdevices/ifrmvp/api/infrared/model/InfraredHost.kt

@@ -0,0 +1,6 @@
+package com.flipperdevices.ifrmvp.api.infrared.model
+
+enum class InfraredHost(val url: String) {
+    DEV("https://infrared.dev.flipp.dev/"),
+    PROD("https://infrared.flipperzero.one/")
+}