Migrate info to new ble api #1001
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
makeevrserg
commented
Dec 11, 2024
...ents/info/impl/src/main/java/com/flipperdevices/info/impl/viewmodel/DeviceStatusViewModel.kt
Show resolved
Hide resolved
LionZXY
reviewed
Dec 11, 2024
...tlin/com/flipperdevices/bridge/connection/feature/getinfo/impl/api/FGetInfoFeatureApiImpl.kt
Outdated
Show resolved
Hide resolved
makeevrserg
commented
Dec 12, 2024
.../flipperdevices/bridge/connection/feature/devicecolor/impl/api/FDeviceColorFeatureApiImpl.kt
Outdated
Show resolved
Hide resolved
Base automatically changed from
makeevrserg/new-ble-api/connection-service
to
makeevrserg/new-ble-api/dev
December 15, 2024 21:10
makeevrserg
force-pushed
the
makeevrserg/new-ble-api/info
branch
from
cdafaf3 to
2e3cb15
Compare
makeevrserg
commented
Dec 18, 2024
| @@ -9,4 +10,5 @@ interface FDevicePersistedStorage { | |||
| suspend fun addDevice(device: FDeviceBaseModel) | |||
| suspend fun removeDevice(id: String) | |||
| fun getAllDevices(): Flow<List<FDeviceBaseModel>> | |||
| suspend fun setCurrentDeviceColor(hardwareColor: HardwareColor) | |||
There was a problem hiding this comment.
Not setDeviceColor(id: String, hardwareColor: HardwareColor) because we can't get color when not connected to device
makeevrserg
commented
Dec 18, 2024
| override val humanReadableName: String = "Flipper $name" | ||
| override val humanReadableName: String = "Flipper $name", | ||
| @Serializable(HardwareColorSerializer::class) | ||
| val hardwareColor: FlipperZeroBle.HardwareColor |
There was a problem hiding this comment.
May be better to add interface ColoredDevice { val hardwareColor....} but we HardwareColor currently linked specificly to FlipperZero
makeevrserg
commented
Dec 18, 2024
|
|
||
| enum HardwareColor { |
There was a problem hiding this comment.
Locate HardwareColor specifically into FlipeprZeroBle because it's request now linked only for this device model
makeevrserg
commented
Dec 18, 2024
| @@ -99,9 +100,10 @@ class UpdateScreenDecomposeComponent @AssistedInject constructor( | |||
| deeplink = deeplink, | |||
| deviceStatus = deviceStatus, | |||
| connectViewModel = connectViewModel, | |||
| hardwareColor = flipperColor, | |||
| hardwareColor = HardwareColor.fromValue(flipperColor.value), // TODO change after full migration | |||
There was a problem hiding this comment.
Some other modules non-related to this PR still requires old HardwareColor
makeevrserg
force-pushed
the
makeevrserg/new-ble-api/dev
branch
from
d7793ea to
08762db
Compare
makeevrserg
force-pushed
the
makeevrserg/new-ble-api/info
branch
from
6554b0c to
b5bd897
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Background
Migrate main screen module to new api
Changes
Test plan