Fix crash on appication from unknown source #723
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
LionZXY
reviewed
Oct 23, 2023
| @@ -9,7 +9,7 @@ import javax.inject.Inject | |||
| @ContributesBinding(AppGraph::class, SelfUpdaterSourceApi::class) | |||
| class SelfUpdaterUnknown @Inject constructor() : SelfUpdaterSourceApi { | |||
| override suspend fun checkUpdate(manual: Boolean): SelfUpdateResult { | |||
| throw NotImplementedError() | |||
There was a problem hiding this comment.
What about try catch in SelfUpdaterApiImpl#startCheckUpdate?
LionZXY
approved these changes
Oct 23, 2023
| @@ -29,6 +29,9 @@ class SelfUpdaterApiImpl @Inject constructor( | |||
| } | |||
| return try { | |||
| selfUpdaterSourceApi.checkUpdate(manual = manual) | |||
| } catch (e: Exception) { | |||
| info { "Self update error: $e" } | |||
There was a problem hiding this comment.
NIT: In this case you should use error logger
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Background
Now we have crash on install
Changes
Return no updates on unknown source
Test plan
Try to install app from unknown source