Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[FL-3618] Infrared remote button index support #3180

Merged
merged 75 commits into from
Nov 10, 2023
Merged

[FL-3618] Infrared remote button index support #3180

merged 75 commits into from
Nov 10, 2023

Conversation

gsurkov
Copy link
Member

@gsurkov gsurkov commented Oct 31, 2023 •
edited by skotopes
Loading

What's new

  • Refactor RpcApp subsystem, simplify API, add Doxygen comments
  • Add support for sending Infrared signals by index (solves the duplicate name issue)

Verification

  • Modify the companion app so that it would send button indices instead of names (use this protobuf version
  • Set "Log Level" to at least "Debug" on Flipper in order to see the debug output.
  • Verify that both old syntax (button names) and the new one (button indices) work properly.

Checklist (For Reviewer)

  • PR has description of feature/bug or link to Confluence/Jira task
  • Description contains actions to verify feature/bugfix
  • I've built this code, uploaded it to the device and verified feature/bugfix

gsurkov added 30 commits October 20, 2023 16:26
@gsurkov
Do not load all signals at once (Draft)
ea9896d
@gsurkov
Minor cleanup
aae1c7e
@gsurkov
Minor cleanup (x2)
2992c07
@gsurkov
Refactor remote renaming
bfc1814
@gsurkov
Improve function signatures
e11df87
@gsurkov
Rename infrared_remote functions
6ca330f
@gsurkov
Optimise signal loading
5b2899d
@gsurkov
Implement adding signals to remote
0cb685f
@gsurkov
Add read_name() method
ce24c21
@gsurkov
Deprecate a function
cf4ae22
@gsurkov
Partially implement deleting signals (draft)
d9d1ada
@gsurkov
Use m-array instead of m-list for signal name directory
3f5b32f
@gsurkov
Use plain C strings instead of furi_string
f0c5854
@gsurkov
Implement deleting signals
489c8d0
@gsurkov
Implement deleting signals via generalised callback
d8295fc
@gsurkov
Implement renaming signals
c3df91d
@gsurkov
Rename some types
ff19ad1
@gsurkov
Some more renaming
ca16a37
@gsurkov
Remove unused type
436f05a
@gsurkov
Implement inserting signals (internal use)
25232db
@gsurkov
Improve InfraredMoveView
2a907aa
@gsurkov
Send an event to move a signal
3eeab28
@gsurkov
Remove unused type
5643fb4
@gsurkov
Implement moving signals
a50b973
@gsurkov
Implement creating new remotes with one signal
9f65c07
@gsurkov
Un-deprecate and rename a function
f90562e
@gsurkov
Add InfraredRemote API docs
46c9967
@gsurkov
Merge remote-tracking branch 'origin/dev' into gsurkov/3456_ir_big_re…
71eb52e 
…mote_oom
@gsurkov
Add InfraredSignal API docs
ef7ce17
@gsurkov
Fix PVS warnings
f09de18
@gsurkov gsurkov requested a review from drunkbatya as a code owner October 31, 2023 16:55
@github-actions GitHub Actions
Copy link

github-actions bot commented Oct 31, 2023 •
edited
Loading

Compiled f7 firmware for commit f391d92f:

@gsurkov gsurkov marked this pull request as draft October 31, 2023 16:59
@hedger hedger added the Infrared Infrared app label Oct 31, 2023
@github-actions GitHub Actions
Copy link

github-actions bot commented Nov 1, 2023 •
edited
Loading

PVS-Studio report for commit 2799d50c:

@Programistich Programistich mentioned this pull request Nov 8, 2023
Closed
@gsurkov gsurkov marked this pull request as ready for review November 9, 2023 15:18
@skotopes skotopes merged commit 49dcf81 into dev Nov 10, 2023
@skotopes skotopes deleted the gsurkov/3618_ir_duplicate_buttons branch November 10, 2023 07:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@skotopes skotopes skotopes approved these changes

@DrZlo13 DrZlo13 Awaiting requested review from DrZlo13 DrZlo13 is a code owner

@hedger hedger Awaiting requested review from hedger hedger is a code owner

@nminaylov nminaylov Awaiting requested review from nminaylov nminaylov is a code owner

@Skorpionm Skorpionm Awaiting requested review from Skorpionm Skorpionm is a code owner

@gornekich gornekich Awaiting requested review from gornekich gornekich is a code owner

@Astrrra Astrrra Awaiting requested review from Astrrra

@drunkbatya drunkbatya Awaiting requested review from drunkbatya

Assignees
No one assigned
Labels
Infrared Infrared app
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@gsurkov @skotopes @hedger