Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enclose original value in NUL byte found exception #396

Closed
wants to merge 1 commit into from

Conversation

ysangkok
Copy link
Contributor

If you get many null byte found exceptions, it's hard to find which values are
triggering it. Let's put the original value in there, then it might be easier
for the consumers.

Copy link
Contributor

@telser telser left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The desire to distinguish where the NUL byte is definitely real. But we made an intentional decision to not print raw values at the lowest level so that there was not a sensitive information leak. Since we can't know if the value is safe to print, we don't.

As it is I don't think we'd want to do this, but I'm trying to think if there is a reasonable way to get the distinguishing of values and prevent the printing of potentially sensitive information.

@ysangkok ysangkok closed this Dec 16, 2024
@ysangkok ysangkok deleted the nul-byte-found branch December 16, 2024 15:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants