Add initial support for identity columns #398
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jlavelle
requested changes
Dec 31, 2024
orville-postgresql/src/Orville/PostgreSQL/Marshall/FieldDefinition.hs
Outdated
Show resolved
Hide resolved
- Expr support for column identity is added for columns that should be generated always or only by default - There is some oddity here. The specification for creating an identity column is to add a constraint. However when looking up in the catalog identity information is not held with other constraints. - Field definitions can be marked as identity - Support for identity at the field definition limits to non-nullable fields, as is the case in PostgreSQL. - AutoMigration support for marking column identity There is additional work needed for full support. This is left for the future. Particularly, identity columns can take options for the underlying sequence. However, supporting that will require being able to look up said sequence using a catalog table not currently supported: pg_depend.
telser
force-pushed
the
telser/identity-columns
branch
from
920d774 to
9c37a4e
Compare
jlavelle
approved these changes
Dec 31, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Expr support for column identity is added for columns that should be generated always or only by default
Field definitions can be marked as identity
Support for identity at the field definition limits to non-nullable fields, as is the case in PostgreSQL.
AutoMigration support for marking column identity
There is additional work needed for full support. This is left for the future. Particularly, identity columns can take options for the underlying sequence. However, supporting that will require being able to look up said sequence using a catalog table not currently supported: pg_depend.