Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(breaking): sampling ratio yaml config #3034

Merged
merged 3 commits into from
May 1, 2024
Merged

fix(breaking): sampling ratio yaml config #3034

merged 3 commits into from
May 1, 2024

Conversation

markphelps
Copy link
Collaborator

YAML config should be snake case

We really need to figure out a way to automate this check as it's bitten us before. Anyone have any ideas?

@markphelps markphelps requested a review from a team as a code owner April 30, 2024 18:02
@markphelps markphelps mentioned this pull request Apr 30, 2024
Merged
GeorgeMac
GeorgeMac approved these changes May 1, 2024
View reviewed changes
Copy link
Member

@GeorgeMac GeorgeMac left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice

@markphelps markphelps merged commit 188a072 into main May 1, 2024
29 checks passed
@markphelps markphelps deleted the fix-sampling-ratio-yaml branch May 1, 2024 11:32
markphelps added a commit that referenced this pull request May 1, 2024
@markphelps
Merge branch 'cloud' into cloud-link
1f1d6d3 
* cloud:
  chore: revert rm config
  chore: add test to catch invalid struct tags (#3035)
  feat(cmd/flipt): wire in flipt client listener
  fix(breaking): sampling ratio yaml config (#3034)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@GeorgeMac GeorgeMac GeorgeMac approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@markphelps @GeorgeMac