perf(fs/git): only fetch known or newly requested references #3100
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is an optimization to ensure that we only ever fetch either tracked or newly requested references from the upstream.
Prior to this change, we always fetched all references from the upstream.
Now instead, we always pull the main reference, plus any newly requested refs or previously fetched refs still in the LRU.
I just added an additional change to this, to ensure that when a branch is supplied (only a branch, not a tag or SHA), that we also perform a single branch clone. So that we don't start off with a full clone.
One user reported to us that a new branch in their upstream was unnecessarily fetched and this caused memory pressure on their instance and it OOMed.
Their relevant feedback on this change: