Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

added tests for issue #141 #144

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Conversation

atuttle
Copy link

@atuttle atuttle commented Oct 5, 2018

While my findings don't totally agree with what's described in #141, they do show some bugs. In particular, it seems like revert doesn't work at all unless I'm misunderstanding how to use it, or I've made a JS variable memory-reference error).

Plus, I don't see any other tests for revert, so now there will be a few. 😄

  83 passing (227ms)
  4 failing

  1) deep-diff
       regression test for issue #141
         reverts changes correctly when both values are truthy:
     Error: expected 'hello' to equal 1
      at Assertion.assert (node_modules/expect.js/index.js:96:13)
      at Assertion.be.Assertion.equal (node_modules/expect.js/index.js:216:10)
      at Context.<anonymous> (test/tests.js:607:31)

  2) deep-diff
       regression test for issue #141
         reverts changes correctly when both values are falsey:
     Error: expected 'hello' to equal -1
      at Assertion.assert (node_modules/expect.js/index.js:96:13)
      at Assertion.be.Assertion.equal (node_modules/expect.js/index.js:216:10)
      at Context.<anonymous> (test/tests.js:613:31)

  3) deep-diff
       regression test for issue #141
         reverts changes correctly when the new value is truthy:
     Error: expected 3 to equal 1
      at Assertion.assert (node_modules/expect.js/index.js:96:13)
      at Assertion.be.Assertion.equal (node_modules/expect.js/index.js:216:10)
      at Context.<anonymous> (test/tests.js:619:31)

  4) deep-diff
       regression test for issue #141
         reverts changes correctly when the new value is falsey:
     Error: expected 1 to equal -1
      at Assertion.assert (node_modules/expect.js/index.js:96:13)
      at Assertion.be.Assertion.equal (node_modules/expect.js/index.js:216:10)
      at Context.<anonymous> (test/tests.js:625:31)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant