Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

record preconditioning failureCause #760

Closed
gernot-h opened this issue Feb 14, 2024 · 1 comment · Fixed by #763
Closed

record preconditioning failureCause #760

gernot-h opened this issue Feb 14, 2024 · 1 comment · Fixed by #763

Comments

@gernot-h
Copy link
Contributor

gernot-h commented Feb 14, 2024 •
edited
Loading

By chance, I noticed that our Astra L Hybrid's door was not locked/closed correctly by looking at the debug log:

2024-02-14 22:14:51,368 :: DEBUG :: response body: {...
"preconditioning":{"airConditioning":{"createdAt":"2024-02-14T21:07:48Z","updatedAt":"2024-02-14T21:07:48Z","status":"Failure","failureCause":"DoorOpened","programs":[{"enabled":false,"slot":1,"recurrence":"Daily","start":"PT7H30M","occurence":{"day":["Mon","Tue","Wed","Thu","Fri"]}}]}}

The get_vehicleinfo API also reported the status, but it didn't mention the helpful failureCause.

I think support for this field was once in the code, but got removed in 619cefd. I wonder whether there was a specific reason to remove this field?

I need to do more tests tomorrow, for now I prefer to keep the car's door closed over night. ;-)
gernot-h added a commit to gernot-h/psa_car_controller that referenced this issue Feb 15, 2024
@gernot-h
feat: make preconditioning failure available (in API)
87aea7d 
The preconditioning element has an interesting field called
"failureCause" which reports error conditions like opened doors, battery
low state etc preventing the preconditioning to run. These errors are
interesting, so make them available in our API.

This field was removed in 619cefd, not sure why, so add it again.

Fixes flobz#760.
@gernot-h gernot-h mentioned this issue Feb 15, 2024
Merged
@gernot-h
Copy link
Contributor Author

gernot-h commented Feb 15, 2024 •
edited
Loading

Indeed, we just need to re-add some of the lines once removed in 619cefd to make the information appear in get_vehicleinfo again, see #763.

gernot-h added a commit to gernot-h/psa_car_controller that referenced this issue Mar 5, 2024
@gernot-h
feat: make preconditioning failure available (in API)
1c069e4 
The preconditioning element has an interesting field called
"failureCause" which reports error conditions like opened doors, battery
low state etc preventing the preconditioning to run. These errors are
interesting, so make them available in our API.

This field was removed in 619cefd, not sure why, so add it again.

Fixes flobz#760.
flobz pushed a commit that referenced this issue Mar 19, 2024
@gernot-h @flobz
feat: make preconditioning failure available (in API)
b22cb7c 
The preconditioning element has an interesting field called
"failureCause" which reports error conditions like opened doors, battery
low state etc preventing the preconditioning to run. These errors are
interesting, so make them available in our API.

This field was removed in 619cefd, not sure why, so add it again.

Fixes #760.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feat: make preconditioning failure available (in API) gernot-h/psa_car_controller
1 participant
@gernot-h