feat: make preconditioning failure available (in API) #763
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
You can now see the failureCause in the API:
|
|
thanks ! :) |
The preconditioning element has an interesting field called "failureCause" which reports error conditions like opened doors, battery low state etc preventing the preconditioning to run. These errors are interesting, so make them available in our API. This field was removed in 619cefd, not sure why, so add it again. Fixes flobz#760.
gernot-h
force-pushed
the
feat-preconditioning-failureCause
branch
from
87aea7d
to
1c069e4
Compare
|
@flobz, I rebased this to master now, so the tests are all green again. I also just re-applied this change to my local installation, et voila, it told me the boot of our car (again) wasn't closed correctly. So I would really love to see this merged into |
|
lgtm thanks |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The preconditioning element has an interesting field called "failureCause" which reports error conditions like opened doors, battery low state etc preventing the preconditioning to run. These errors are interesting, so make them available in our API.
This field was removed in 619cefd, not sure why, so add it again.
Fixes #760.