Fixes #26

thanks @FlowMo7
floschu · Jun 22, 2021 · da6568e · da6568e
1 parent 13b3e3e
commit da6568e
Show file tree

Hide file tree

Showing 3 changed files with 27 additions and 0 deletions.
diff --git a/CHANGELOG.md b/CHANGELOG.md
@@ -9,6 +9,7 @@
 - Update kotlinx.coroutines to `1.4.3`.
 - Remove kotlin as `api` dependency.
 - Remove `ControllerLog.default`.
+- Lazily start controller when accessing `Controller.effects` field (#26)
 
 ## `[0.13.1]` - 2020-09-13
 

diff --git a/control-core/src/main/kotlin/at/florianschuster/control/implementation.kt b/control-core/src/main/kotlin/at/florianschuster/control/implementation.kt
@@ -142,6 +142,7 @@ internal class ControllerImplementation<Action, Mutation, State, Effect>(
         get() = if (stubEnabled) {
             stubbedEffectFlow.receiveAsFlow().cancellable()
         } else {
+            if (controllerStart is ControllerStart.Lazy) start()
             effectsChannel.receiveAsFlow().cancellable()
         }
 

diff --git a/control-core/src/test/kotlin/at/florianschuster/control/ImplementationTest.kt b/control-core/src/test/kotlin/at/florianschuster/control/ImplementationTest.kt
@@ -327,6 +327,31 @@ internal class ImplementationTest {
         sut.cancel()
     }
 
+    @Test
+    fun `controller is started lazily when only effects field is accessed`() {
+        val sut = ControllerImplementation<Int, Int, Int, String>(
+            scope = testCoroutineScope,
+            dispatcher = testCoroutineScope.defaultScopeDispatcher(),
+            controllerStart = ControllerStart.Lazy,
+            initialState = 0,
+            mutator = { action -> flowOf(action) },
+            reducer = { mutation, _ -> mutation },
+            actionsTransformer = { actions ->
+                merge(actions, flow {
+                    emitEffect("actionsTransformer started")
+                })
+            },
+            mutationsTransformer = { mutations -> mutations },
+            statesTransformer = { states -> states },
+            tag = "ImplementationTest.EffectController",
+            controllerLog = ControllerLog.None
+        )
+
+        val effects = sut.effects.testIn(testCoroutineScope)
+
+        effects expect emissions(listOf("actionsTransformer started"))
+    }
+
     private fun CoroutineScope.createAlwaysSameStateController() =
         ControllerImplementation<Unit, Unit, Int, Nothing>(
             scope = this,