Move connected event to post-flow-join #109
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The `connected` event was being emitted after the Flowdock connection was *initiated*, but that meant the event was dispatched before there was actually a live connection to work with. This meant sending messages on connect, for example, wouldn't work. The `connected` event is now correctly dispatched once the connection to Flowdock is fully established and authed, and all flows have been joined.
|
Anyone out there? :) |
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
connectedevent was being emitted after the Flowdock connection wasinitiated, but that meant the event was dispatched before there was actually
a live connection to work with. This meant sending messages on connect, for
example, wouldn't work.
The
connectedevent is now correctly dispatched once the connection toFlowdock is fully established and authed, and all flows have been joined.