in_node_exporter_metrics: Add macOS into a table of supported metrics #1197
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Sep 20, 2023
Signed-off-by: Hiroshi Hatake <[email protected]>
cosmo0920
force-pushed
the
cosmo0920-add-descriptions-for-macOS-supported-collectors
branch
from
39361ed to
6f222d1
Compare
Co-authored-by: Pat <[email protected]> Signed-off-by: Hiroshi Hatake <[email protected]>
patrick-stephens
approved these changes
Oct 2, 2023
…rted-collectors Signed-off-by: Pat <[email protected]>
patrick-stephens
deleted the
cosmo0920-add-descriptions-for-macOS-supported-collectors
branch
|
@cosmo0920 can you check if the new collectors need to be marked now? |
|
Sure. I'll handle about it. |
|
I checked the documentation but the all of documented list is described correctly. The description of filesystem metrics is absent on the table. So, I sent a PR to add it here: #1279 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is corresponding to fluent/fluent-bit#7947.