Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

pipelines: filters: parser: Add a nest_under parameter #1543

Merged
merged 5 commits into from
Jan 22, 2025

Conversation

RaJiska
Copy link
Contributor

@RaJiska RaJiska commented Jan 13, 2025

Documentation for PR fluent/fluent-bit#9828

@RaJiska RaJiska requested review from a team as code owners January 13, 2025 09:44
Copy link
Member

@alexakreizinger alexakreizinger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

made a few suggestions for style and clarity, but LGTM!

and thanks for opening a PR :)

pipeline/filters/parser.md Outdated Show resolved Hide resolved
pipeline/filters/parser.md Outdated Show resolved Hide resolved
pipeline/filters/parser.md Outdated Show resolved Hide resolved
pipeline/filters/parser.md Outdated Show resolved Hide resolved
RaJiska and others added 4 commits January 18, 2025 12:24
Co-authored-by: Alexa Kreizinger <[email protected]>
Signed-off-by: Doriann Corlouër <[email protected]>
Co-authored-by: Alexa Kreizinger <[email protected]>
Signed-off-by: Doriann Corlouër <[email protected]>
Co-authored-by: Alexa Kreizinger <[email protected]>
Signed-off-by: Doriann Corlouër <[email protected]>
Co-authored-by: Alexa Kreizinger <[email protected]>
Signed-off-by: Doriann Corlouër <[email protected]>
@RaJiska
Copy link
Contributor Author

RaJiska commented Jan 18, 2025

All good to me! Thanks @alexakreizinger for helping making it clearer and in proper English~~

@alexakreizinger alexakreizinger merged commit c721db4 into fluent:master Jan 22, 2025
3 checks passed
@RaJiska
Copy link
Contributor Author

RaJiska commented Jan 23, 2025

Hi @alexakreizinger , I'm not entirely sure how the PR flow happens on this repo, but I see it has been merged already, yet the PR linked to this documentation hasn't been approved nor merged yet. If this goes live this might cause discrepancy between the documentation and actual options available until the referenced PR is merged as well.

@0x4c6565
Copy link

Hi @alexakreizinger , I'm not entirely sure how the PR flow happens on this repo, but I see it has been merged already, yet the PR linked to this documentation hasn't been approved nor merged yet. If this goes live this might cause discrepancy between the documentation and actual options available until the referenced PR is merged as well.

I've just spent a good 30 minutes scratching my head as to why nest_under isn't working! Mystery solved :)

@lockewritesdocs
Copy link
Contributor

@RaJiska, thanks for pointing out this discrepancy! We reverted the docs change until the related linked PR is merged with the appropriate code changes.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants