-
Notifications
You must be signed in to change notification settings - Fork 502
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
pipelines: filters: parser: Add a nest_under parameter #1543
pipelines: filters: parser: Add a nest_under parameter #1543
Conversation
Signed-off-by: Ra'Jiska <[email protected]>
6458fe0
to
e76f785
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
made a few suggestions for style and clarity, but LGTM!
and thanks for opening a PR :)
Co-authored-by: Alexa Kreizinger <[email protected]> Signed-off-by: Doriann Corlouër <[email protected]>
Co-authored-by: Alexa Kreizinger <[email protected]> Signed-off-by: Doriann Corlouër <[email protected]>
Co-authored-by: Alexa Kreizinger <[email protected]> Signed-off-by: Doriann Corlouër <[email protected]>
Co-authored-by: Alexa Kreizinger <[email protected]> Signed-off-by: Doriann Corlouër <[email protected]>
All good to me! Thanks @alexakreizinger for helping making it clearer and in proper English~~ |
Hi @alexakreizinger , I'm not entirely sure how the PR flow happens on this repo, but I see it has been merged already, yet the PR linked to this documentation hasn't been approved nor merged yet. If this goes live this might cause discrepancy between the documentation and actual options available until the referenced PR is merged as well. |
I've just spent a good 30 minutes scratching my head as to why |
@RaJiska, thanks for pointing out this discrepancy! We reverted the docs change until the related linked PR is merged with the appropriate code changes. |
Documentation for PR fluent/fluent-bit#9828