-
Notifications
You must be signed in to change notification settings - Fork 466
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
implement internalTrafficPolicy for daemonsets #461
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the PR @Joerit. I agree that this is a desirable capability. I've added a couple of suggestions, and to get this merged you'd also need to bump the chart version and update the changelog annotations.
merged latest main in, and bumped the chart version + annotation |
@Joerit could you sign the DCO? |
@stevehipwell i have
|
@Joerit did you amend all of your commits to be signed off? My suggestion would be to squash your commits and make sure the resulting commit has the correct sign off. |
@stevehipwell |
@Joerit the DCO looks good now, but you're out of date with the |
Signed-off-by: Joeri Temmerman <[email protected]> typo'd DaemonSet Signed-off-by: Joeri <[email protected]> Apply suggestions from code review Co-authored-by: Steve Hipwell <[email protected]> Signed-off-by: Joeri Temmerman <[email protected]> bump chart version, annotation Signed-off-by: Joeri <[email protected]>
@stevehipwell sorry, rebased. |
@Joerit if you can rebase your automation should work correctly. |
Signed-off-by: Joeri Temmerman <[email protected]>
Signed-off-by: Joeri Temmerman <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Hi 👋
we're using fluentbit as a logstash dropin (i.e. tcp input, output to ES)
deploying as a daemonset with a service causes applications to just push to a random pod running on a random node
internalTrafficPolicy makes the service route to the instance running on the local node (so avoids cross-node traffic)
this change works for my usecase.
Greetings,
Joeri