fixed CollectionShouldNotContainProperty being too aggresive (#68)

* wip * fixed test
fluentassertions · Jul 5, 2018 · 9ca05f6 · 9ca05f6
1 parent 27c9ec1
commit 9ca05f6
Show file tree

Hide file tree

Showing 3 changed files with 25 additions and 3 deletions.
diff --git a/src/FluentAssertions.Analyzers.Tests/Tips/CollectionTests.cs b/src/FluentAssertions.Analyzers.Tests/Tips/CollectionTests.cs
@@ -91,10 +91,10 @@ public class CollectionTests
         [AssertionDataTestMethod]
         [AssertionDiagnostic("actual.Any(x => x.BooleanProperty).Should().BeFalse({0});")]
         [AssertionDiagnostic("actual.Where(x => x.BooleanProperty).Should().BeEmpty({0});")]
-        [AssertionDiagnostic("actual.Should().OnlyContain(x => !x.BooleanProperty{0});")]
+        [AssertionDiagnostic("actual.Should().OnlyContain(x => !x.BooleanProperty{0});", ignore: true)]
         [AssertionDiagnostic("actual.AsEnumerable().Any(x => x.BooleanProperty).Should().BeFalse({0}).And.ToString();")]
         [AssertionDiagnostic("actual.AsEnumerable().Where(x => x.BooleanProperty).Should().BeEmpty({0}).And.ToString();")]
-        [AssertionDiagnostic("actual.AsEnumerable().Should().OnlyContain(x => !x.BooleanProperty{0}).And.ToString();")]
+        [AssertionDiagnostic("actual.AsEnumerable().Should().OnlyContain(x => !x.BooleanProperty{0}).And.ToString();", ignore: true)]
         [Implemented]
         public void CollectionShouldNotContainProperty_TestAnalyzer(string assertion) => VerifyCSharpDiagnosticCodeBlock<CollectionShouldNotContainPropertyAnalyzer>(assertion);
 

diff --git a/src/FluentAssertions.Analyzers.Tests/Tips/SanityTests.cs b/src/FluentAssertions.Analyzers.Tests/Tips/SanityTests.cs
@@ -189,5 +189,25 @@ public static void Main()
 
             DiagnosticVerifier.VerifyCSharpDiagnosticUsingAllAnalyzers(source);
         }
+
+        [TestMethod]
+        [Implemented(Reason = "https://github.com/fluentassertions/fluentassertions.analyzers/issues/64")]
+        public void CollectionShouldNotContainProperty_WhenAssertionIsIdiomatic_ShouldNotTrigger()
+        {            
+            const string source = @"
+using FluentAssertions;
+using FluentAssertions.Extensions;
+
+public class TestClass
+{
+    public static void Main()
+    {
+        var list = new[] { string.Empty };
+        list.Should().OnlyContain(e => e.Contains(string.Empty));
+    }
+}"; 
+
+            DiagnosticVerifier.VerifyCSharpDiagnosticUsingAllAnalyzers(source);
+        }
     }
 }
diff --git a/src/FluentAssertions.Analyzers/Tips/Collections/CollectionShouldNotContainProperty.cs b/src/FluentAssertions.Analyzers/Tips/Collections/CollectionShouldNotContainProperty.cs
@@ -23,7 +23,7 @@ protected override IEnumerable<FluentAssertionsCSharpSyntaxVisitor> Visitors
             {
                 yield return new AnyShouldBeFalseSyntaxVisitor();
                 yield return new WhereShouldBeEmptySyntaxVisitor();
-                yield return new ShouldOnlyContainNotSyntaxVisitor();
+                // TODO: yield return new ShouldOnlyContainNotSyntaxVisitor();
             }
         }
 
@@ -70,10 +70,12 @@ protected override ExpressionSyntax GetNewExpression(ExpressionSyntax expression
 
                 return GetNewExpression(newExpression, NodeReplacement.RenameAndPrependArguments("BeEmpty", "NotContain", remove.Arguments));
             }
+            /*
             else if (properties.VisitorName == nameof(CollectionShouldNotContainPropertyAnalyzer.ShouldOnlyContainNotSyntaxVisitor))
             {
                 return GetNewExpression(expression, NodeReplacement.RenameAndNegateLambda("OnlyContain", "NotContain"));
             }
+            */
             throw new System.InvalidOperationException($"Invalid visitor name - {properties.VisitorName}");
         }
     }