Skip to content

Commit

Permalink
Merge pull request #1274 from dsalaza4/main
Browse files Browse the repository at this point in the history
feat(back): #1273 upgrade to node 21
  • Loading branch information
dsalaza4 authored Jan 19, 2024
2 parents 066cfaa + 60aea18 commit 440966e
Show file tree
Hide file tree
Showing 7 changed files with 28 additions and 9 deletions.
8 changes: 4 additions & 4 deletions docs/src/api/extensions/node.js.md
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,7 @@ Types:
- makeNodeJsModules (`function { ... } -> package`):
- name (`str`):
Custom name to assign to the build step, be creative, it helps in debugging.
- nodeJsVersion (`enum [ "18" ]`):
- nodeJsVersion (`enum [ "18" "20" "21" ]`):
Node.js version to use.
- packageJson (`package`):
Path to the `package.json` of your project.
Expand Down Expand Up @@ -64,7 +64,7 @@ Example:
let
hello = makeNodeJsModules {
name = "hello-world-npm";
nodeJsVersion = "16";
nodeJsVersion = "21";
packageJson =
projectPath "/path/to/my/project/makes/example/package.json";
packageLockJson =
Expand Down Expand Up @@ -116,7 +116,7 @@ Types:
- makeNodeJsEnvironment (`function { ... } -> package`):
- name (`str`):
Custom name to assign to the build step, be creative, it helps in debugging.
- nodeJsVersion (`enum [ "18" ]`):
- nodeJsVersion (`enum [ "18" "20" "21" ]`):
Node.js version to use.
- packageJson (`package`):
Path to the `package.json` of your project.
Expand Down Expand Up @@ -169,7 +169,7 @@ Example:
let
hello = makeNodeJsEnvironment {
name = "hello-world-npm";
nodeJsVersion = "16";
nodeJsVersion = "21";
packageJson =
projectPath "/path/to/my/project/makes/example/package.json";
packageLockJson =
Expand Down
19 changes: 19 additions & 0 deletions src/args/lint-git-commit-msg/commitlint/package-lock.json

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion src/args/lint-git-commit-msg/default.nix
Original file line number Diff line number Diff line change
Expand Up @@ -12,7 +12,7 @@
}: let
commitlint = makeNodeJsEnvironment {
name = "commitlint";
nodeJsVersion = "18";
nodeJsVersion = "21";
packageJson = ./commitlint/package.json;
packageLockJson = ./commitlint/package-lock.json;
};
Expand Down
2 changes: 1 addition & 1 deletion src/args/lint-with-ajv/default.nix
Original file line number Diff line number Diff line change
Expand Up @@ -18,7 +18,7 @@ makeDerivation {
source = [
(makeNodeJsEnvironment {
name = "ajv-cli";
nodeJsVersion = "18";
nodeJsVersion = "21";
packageJson = ./ajv-cli/package.json;
packageLockJson = ./ajv-cli/package-lock.json;
})
Expand Down
2 changes: 1 addition & 1 deletion src/args/make-node-js-modules/builder.sh
Original file line number Diff line number Diff line change
Expand Up @@ -10,7 +10,7 @@ function main {
--input package.json \
--lock package-lock.json \
--pkg-name "nodejs_${envNodeJsVersion}" \
"--nodejs-${envNodeJsVersion}" \
--include-peer-dependencies \
&& sed -i -e 's/dontNpmInstall ? false/dontNpmInstall ? true/g' node-env.nix # https://github.com/svanderburg/node2nix/issues/134#issuecomment-475809875
}

Expand Down
2 changes: 1 addition & 1 deletion src/args/test-pull-request/default.nix
Original file line number Diff line number Diff line change
Expand Up @@ -12,7 +12,7 @@
}: let
env = makeNodeJsEnvironment {
name = "danger";
nodeJsVersion = "18";
nodeJsVersion = "21";
packageJson = ./package.json;
packageLockJson = ./package-lock.json;
};
Expand Down
2 changes: 1 addition & 1 deletion src/evaluator/modules/format-markdown/default.nix
Original file line number Diff line number Diff line change
Expand Up @@ -47,7 +47,7 @@
source = [
(makeNodeJsEnvironment {
name = "doctoc";
nodeJsVersion = "18";
nodeJsVersion = "21";
packageJson = ./doctoc/package.json;
packageLockJson = ./doctoc/package-lock.json;
})
Expand Down

0 comments on commit 440966e

Please sign in to comment.