feat(back): #1370 add swap to container #1371
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
jpverde
commented
Aug 13, 2024
jpverde
commented
- Added swap configuration for the makes container
- Added swap configuration for the makes container Signed-off-by: John Perez <[email protected]>
|
dsalaza4
reviewed
Aug 13, 2024
| @@ -30,13 +30,28 @@ __nixpkgs__.dockerTools.buildImage { | |||
| __nixpkgs__.gnutar | |||
| __nixpkgs__.gzip | |||
| __nixpkgs__.nixVersions.nix_2_15 | |||
| __nixpkgs__.util-linux | |||
There was a problem hiding this comment.
I think this is unnecessary. You can directly run commands via runCommand in order to configure swap.
dsalaza4
reviewed
Aug 13, 2024
| '') | ||
| # Creat swapfile for the system | ||
| (__nixpkgs__.runCommand "swap-file" { } '' | ||
| dd if=/dev/zero of=/mnt/swapfile bs=1M count=2048 |
There was a problem hiding this comment.
Would this work if the container is provided a volume smaller than 2GB?
dsalaza4
reviewed
Aug 13, 2024
| '') | ||
| # Enable swap | ||
| (__nixpkgs__.runCommand "swap-enable" { } '' | ||
| swapon /mnt/swapfile |
There was a problem hiding this comment.
Suggested change
| swapon /mnt/swapfile | |
| ${__nixpkgs__.util-linux}/bin/swapon /mnt/swapfile |
|
Using swap on containers seems to go further than configuring the container itself 🤔 https://kubernetes.io/blog/2023/08/24/swap-linux-beta/ https://docs.docker.com/engine/containers/resource_constraints/#--memory-swap-details |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.