Skip to content

Commit

Permalink
Temporarily disable Code based profiling when VM Developer Mode is …
Browse files Browse the repository at this point in the history
…enabled (#8578)

Works around #8567 until
`package:vm_service` 15.0.0 is rolled through to Flutter.
  • Loading branch information
bkonyi authored Dec 2, 2024
1 parent 7688d21 commit 2b9dcf9
Showing 1 changed file with 3 additions and 2 deletions.
5 changes: 3 additions & 2 deletions packages/devtools_app/lib/src/service/vm_service_wrapper.dart
Original file line number Diff line number Diff line change
Expand Up @@ -20,7 +20,6 @@ import 'package:vm_service/vm_service.dart';

import '../screens/vm_developer/vm_service_private_extensions.dart';
import '../shared/feature_flags.dart';
import '../shared/globals.dart';
import '../shared/primitives/utils.dart';
import 'json_to_service_cache.dart';

Expand Down Expand Up @@ -143,7 +142,9 @@ class VmServiceWrapper extends VmService {
// running with VM developer mode enabled. This data isn't accessible
// in non-VM developer mode, so not requesting the code profile will
// save on space and network usage.
'_code': preferences.vmDeveloperModeEnabled.value,
// TODO(bkonyi): re-enable when package:vm_service 15.0.0 is rolled
// into Flutter. See https://github.com/flutter/devtools/issues/8567.
// '_code': preferences.vmDeveloperModeEnabled.value,
},
).then((e) => e as CpuSamples);
}
Expand Down

0 comments on commit 2b9dcf9

Please sign in to comment.