Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

License update - Batch 47 #8749

Merged
merged 3 commits into from
Jan 16, 2025
Merged

License update - Batch 47 #8749

merged 3 commits into from
Jan 16, 2025

Conversation

mossmana
Copy link
Contributor

Updates the license headers for:

  1. packages/devtools_app/integration_test/test_infra/run/_in_file_args.dart
  2. packages/devtools_app/integration_test/test_infra/run/_test_app_driver.dart
  3. packages/devtools_app/integration_test/test_infra/run/_utils.dart
  4. packages/devtools_app/integration_test/test_infra/run/run_test.dart
  5. packages/devtools_app/test/test_infra/fixtures/color_console_output_app.dart
  6. packages/devtools_app/test/test_infra/fixtures/debugging_app.dart
  7. packages/devtools_app/test/test_infra/fixtures/debugging_app_async.dart
  8. packages/devtools_app/test/test_infra/fixtures/debugging_app_exception.dart
  9. packages/devtools_app/test/test_infra/fixtures/empty_app.dart
  10. packages/devtools_app/test/test_infra/fixtures/flutter_app/README.md
  11. packages/devtools_app/test/test_infra/fixtures/flutter_app/lib/main.dart
  12. packages/devtools_app/test/test_infra/fixtures/flutter_app/lib/overflow_errors.dart
  13. packages/devtools_app/test/test_infra/fixtures/flutter_app/lib/src/autocomplete.dart
  14. packages/devtools_app/test/test_infra/fixtures/flutter_app/lib/src/autocomplete_export.dart
  15. packages/devtools_app/test/test_infra/fixtures/flutter_app/lib/src/autocomplete_helper_library.dart
  16. packages/devtools_app/test/test_infra/fixtures/flutter_app/lib/src/other_classes.dart
  17. packages/devtools_app/test/test_infra/fixtures/flutter_app/pubspec.yaml
  18. packages/devtools_app/test/test_infra/fixtures/flutter_error_app/README.md
  19. packages/devtools_app/test/test_infra/fixtures/flutter_error_app/lib/main.dart
  20. packages/devtools_app/test/test_infra/fixtures/flutter_error_app/lib/missing_material_error.dart
  21. packages/devtools_app/test/test_infra/fixtures/flutter_error_app/pubspec.yaml
  22. packages/devtools_app/test/test_infra/fixtures/logging_app.dart
  23. packages/devtools_app/test/test_infra/fixtures/memory_app/README.md
  24. packages/devtools_app/test/test_infra/fixtures/memory_app/lib/main.dart
  25. packages/devtools_app/test/test_infra/fixtures/memory_app/pubspec.yaml
  26. packages/devtools_app/test/test_infra/flutter_test_driver.dart
  27. packages/devtools_app/test/test_infra/flutter_test_environment.dart
  28. packages/devtools_app/test/test_infra/flutter_test_storage.dart
  29. packages/devtools_app/test/test_infra/matchers/_golden_matcher_io.dart
  30. packages/devtools_app/test/test_infra/matchers/_golden_matcher_web.dart
  31. packages/devtools_app/test/test_infra/matchers/matchers.dart
  32. packages/devtools_app/test/test_infra/scenes/README.md
  33. packages/devtools_app/test/test_infra/scenes/cpu_profiler/default.dart
  34. packages/devtools_app/test/test_infra/scenes/hello.dart
  35. packages/devtools_app/test/test_infra/scenes/memory/default.dart
  36. packages/devtools_app/test/test_infra/scenes/memory/diff_snapshot.dart
  37. packages/devtools_app/test/test_infra/scenes/performance/default.dart
  38. packages/devtools_app/test/test_infra/scenes/scene_test_extensions.dart
  39. packages/devtools_app/test/test_infra/scenes/standalone_ui/editor_service/simulated_editor.dart
  40. packages/devtools_app/test/test_infra/scenes/standalone_ui/editor_sidebar.dart
  41. packages/devtools_app/test/test_infra/scenes/standalone_ui/mock_editor_widget.dart
  42. packages/devtools_app/test/test_infra/scenes/standalone_ui/property_editor_sidebar.dart
  43. packages/devtools_app/test/test_infra/scenes/standalone_ui/shared/common_ui.dart
  44. packages/devtools_app/test/test_infra/scenes/standalone_ui/shared/utils.dart
  45. packages/devtools_app/test/test_infra/test_data/app_size/apk_analysis.dart
  46. packages/devtools_app/test/test_infra/test_data/app_size/deferred_app.dart
  47. packages/devtools_app/test/test_infra/test_data/app_size/diff_deferred_app.dart
  48. packages/devtools_app/test/test_infra/test_data/app_size/diff_no_deferred_app.dart
  49. packages/devtools_app/test/test_infra/test_data/app_size/new_v8.dart
  50. packages/devtools_app/test/test_infra/test_data/app_size/old_v8.dart
  51. packages/devtools_app/test/test_infra/test_data/app_size/precompiler_trace.dart
  52. packages/devtools_app/test/test_infra/test_data/app_size/sizes.dart
  53. packages/devtools_app/test/test_infra/test_data/app_size/small_sizes.dart
  54. packages/devtools_app/test/test_infra/test_data/app_size/unsupported_file.dart
  55. packages/devtools_app/test/test_infra/test_data/cpu_profiler/cpu_profile.dart
  56. packages/devtools_app/test/test_infra/test_data/cpu_profiler/simple_profile_1.dart
  57. packages/devtools_app/test/test_infra/test_data/cpu_profiler/simple_profile_2.dart
  58. packages/devtools_app/test/test_infra/test_data/debugger/vm_service_object_tree.dart
  59. packages/devtools_app/test/test_infra/test_data/deep_link/fake_responses.dart
  60. packages/devtools_app/test/test_infra/test_data/memory.dart
  61. packages/devtools_app/test/test_infra/test_data/memory/heap/README.md
  62. packages/devtools_app/test/test_infra/test_data/memory/heap/factories.dart
  63. packages/devtools_app/test/test_infra/test_data/memory/heap/heap_data.dart
  64. packages/devtools_app/test/test_infra/test_data/memory/heap/heap_graph_fakes.dart
  65. packages/devtools_app/test/test_infra/test_data/memory/offline/memory_offline_data.dart
  66. packages/devtools_app/test/test_infra/test_data/memory_allocation.dart
  67. packages/devtools_app/test/test_infra/test_data/network.dart
  68. packages/devtools_app/test/test_infra/test_data/performance/_perfetto_events_raw.dart
  69. packages/devtools_app/test/test_infra/test_data/performance/sample_performance_data.dart
  70. packages/devtools_app/test/test_infra/test_data/syntax_highlighting/classes_mixins.dart
  71. packages/devtools_app/test/test_infra/test_data/syntax_highlighting/comments.dart
  72. packages/devtools_app/test/test_infra/test_data/syntax_highlighting/functions.dart
  73. packages/devtools_app/test/test_infra/test_data/syntax_highlighting/keywords.dart
  74. packages/devtools_app/test/test_infra/test_data/syntax_highlighting/literals.dart
  75. packages/devtools_app/test/test_infra/test_data/syntax_highlighting/names.dart
  76. packages/devtools_app/test/test_infra/test_data/syntax_highlighting/operators.dart
  77. packages/devtools_app/test/test_infra/test_data/syntax_highlighting/string_interpolation.dart
  78. packages/devtools_app/test/test_infra/utils/ansi.dart
  79. packages/devtools_app/test/test_infra/utils/debugger_utils.dart
  80. packages/devtools_app/test/test_infra/utils/deep_links_utils.dart
  81. packages/devtools_app/test/test_infra/utils/extent_delegate_utils.dart
  82. packages/devtools_app/test/test_infra/utils/rendering_tester.dart
  83. packages/devtools_app/test/test_infra/utils/sidebar_utils.dart
  84. packages/devtools_app/test/test_infra/utils/test_utils.dart
  85. packages/devtools_app/test/test_infra/utils/tree_utils.dart
  86. packages/devtools_app/test/test_infra/utils/variable_utils.dart

#8216

Pre-launch Checklist

  • I read the [Contributor Guide] and followed the process outlined there for submitting PRs.
  • I read the [Tree Hygiene] wiki page, which explains my responsibilities.
  • I read the [Flutter Style Guide] recently, and have followed its advice.
  • I signed the [CLA].
  • I listed at least one issue that this PR fixes in the description above.
  • I updated/added relevant documentation (doc comments with ///).
  • I added new tests to check the change I am making, or there is a reason for not adding tests.

build.yaml badge

mossmana
mossmana commented Jan 15, 2025
View reviewed changes
packages/devtools_app/test/test_infra/fixtures/flutter_app/lib/main.dart
@@ -1,3 +1,6 @@
// Copyright 2025 The Flutter Authors
// Use of this source code is governed by a BSD-style license that can be
// found in the LICENSE file or at https://developers.google.com/open-source/licenses/bsd.
// FILE: main.dart (Note: Do not remove comment, for testing.)
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@kenzieschmoll Do you happen to know why this comment needs to be at the top of the file? It interferes with the license header check/placement.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like we use this for testing: https://github.com/flutter/devtools/blob/master/packages/devtools_app/integration_test/test/live_connection/debugger_panel_test.dart/#L48. So adding the copyright header to this file may break that test.

mossmana
mossmana commented Jan 15, 2025
View reviewed changes
packages/devtools_app/test/test_infra/utils/rendering_tester.dart Outdated
@@ -1,3 +1,6 @@
// Copyright 2025 The Flutter Authors
// Use of this source code is governed by a BSD-style license that can be
// found in the LICENSE file or at https://developers.google.com/open-source/licenses/bsd.
// Copyright 2020 The Flutter Authors. All rights reserved.
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@kenzieschmoll This was originally attributed to the Flutter Authors and not Chromium. Do you happen to know if this was copied from the Flutter SDK?

Copy link
Contributor Author

@mossmana mossmana Jan 16, 2025 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actually, it looks like it might be copied nearly verbatim from https://github.com/flutter/flutter/blob/5517cc9b3b3bcf12431b47f495e342a30b738835/packages/flutter/test/rendering/rendering_tester.dart#L4 and I just didn't see the comment. I'll revert.

mossmana
mossmana commented Jan 16, 2025
View reviewed changes
packages/devtools_app/test/test_infra/utils/rendering_tester.dart
@@ -1,4 +1,4 @@
// Copyright 2020 The Flutter Authors. All rights reserved.
// Copyright 2014 The Flutter Authors. All rights reserved.
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The code should retain the original header which had 2014 as the copyright date.

@mossmana mossmana marked this pull request as ready for review January 16, 2025 22:05
@mossmana mossmana requested review from elliette, bkonyi and a team as code owners January 16, 2025 22:05
@mossmana mossmana merged commit 7844d6a into flutter:master Jan 16, 2025
24 checks passed
@mossmana mossmana deleted the 8216-batch47 branch January 16, 2025 22:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kenzieschmoll kenzieschmoll kenzieschmoll approved these changes

@elliette elliette Awaiting requested review from elliette elliette is a code owner

@bkonyi bkonyi Awaiting requested review from bkonyi bkonyi is a code owner

Assignees
No one assigned
Labels
release-notes-not-required
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mossmana @kenzieschmoll