Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Property editor validation and nullable argument fixes #8768

Merged
merged 2 commits into from
Jan 16, 2025

Conversation

elliette
Copy link
Member

@elliette elliette commented Jan 16, 2025

This PR fixes a few issues in the Property Editor that are all semi-related:

  1. Validation error "Please enter a string" when editing strings: [Property Editor] "Please enter a string error" #8764
  2. Can't set numeric input to null: [property editor] type mismatch for int field #8714
  3. Can't set optional nullable value to null: [Property Editor] Should be able to set optional nullable value to null #8757
  4. Deleting value in nullable input sets value to null: [property editor] removing value from a non-required field should return to null or default value #8709

Work towards #1948
Fixes #8764, #8714, #8757, #8709

@elliette elliette requested a review from a team as a code owner January 16, 2025 22:33
@elliette elliette requested review from bkonyi and kenzieschmoll and removed request for a team and bkonyi January 16, 2025 22:33
@elliette elliette merged commit 3eb1df7 into flutter:master Jan 16, 2025
24 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Property Editor] "Please enter a string error"
2 participants