Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Property Editor] Handle errors from the Analysis Server #8818

Merged
merged 7 commits into from
Jan 30, 2025
+233 −46
Merged

[Property Editor] Handle errors from the Analysis Server #8818

Changes from 1 commit
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
93737c2
Property editor error handling
elliette Jan 28, 2025
f58c474
Add a test case
elliette Jan 29, 2025
c1394bf
Respond to PR comments
elliette Jan 29, 2025
57089dd
Fix error codes and update test
elliette Jan 29, 2025
ff72e62
Increase bundle size in test
elliette Jan 29, 2025
8bb823a
Add TODOs
elliette Jan 29, 2025
bf86128
Add property name to error
elliette Jan 30, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion packages/devtools_app/benchmark/web_bundle_size_test.dart
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,7 +12,7 @@ import 'package:test/test.dart';

// Benchmark size in kB.
const bundleSizeBenchmark = 5400;
const gzipBundleSizeBenchmark = 1550;
const gzipBundleSizeBenchmark = 1650;
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Bundle size is now 1552kb, therefore bumping 1550 limit to 1650


void main() {
group('Web Compile', () {
Expand Down
Loading