-
Notifications
You must be signed in to change notification settings - Fork 3.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[url_launcher_windows] Correct logging url #8107
Conversation
It looks like this pull request may not have tests. Please make sure to add tests before merging. If you need an exemption, contact "@test-exemption-reviewer" in the #hackers channel in Discord (don't just cc them here, they won't see it!). If you are not sure if you need tests, consider this rule of thumb: the purpose of a test is to make sure someone doesn't accidentally revert the fix. Ask yourself, is there anything in your PR that you feel it is important we not accidentally revert back to how it was before your fix? Reviewers: Read the Tree Hygiene page and make sure this patch meets those guidelines before LGTMing. The test exemption team is a small volunteer group, so all reviewers should feel empowered to ask for tests, without delegating that responsibility entirely to the test exemption group. |
Thanks for the contribution! You’ve checked boxes in the PR checklist above that are not reflected in this PR, so I’m assuming this is a work in progress and am marking it as a Draft. Please review the checklist, updating the PR as appropriate, and when the checklist reflects the state of the PR as posted please feel free to mark it as ready for review.
Please make sure to complete this step as well, so that it's clear what the problem you are trying to solve is. It's not currently clear what the motivation for this change is. |
5ee560b
to
3b55994
Compare
What are the documented version, changelog, and test exemption reasons that this PR falls under? |
17e0115
to
8cdaa4f
Compare
Hi @stuartmorgan, this PR should be ready to go now! Sorry for the repeated review loops! |
I would still like to have a response to flutter/flutter#159009 (comment) since it's not clear to me why this behavior is more correct than the current behavior, and what the actual problem being solved is. |
@stuartmorgan Responded to the issue! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM with one comment.
auto label is removed for flutter/packages/8107, due to - The status or check suite Linux analyze master has failed. Please fix the issues identified (or deflake) before re-applying this label. |
flutter/packages@6554751...3c3bc68 2025-01-11 49699333+dependabot[bot]@users.noreply.github.com [dependabot]: Bump the test-dependencies group across 2 directories with 1 update (flutter/packages#8412) 2025-01-11 49699333+dependabot[bot]@users.noreply.github.com [dependabot]: Bump org.json:json from 20241224 to 20250107 in /packages/in_app_purchase/in_app_purchase_android/example/android/app (flutter/packages#8411) 2025-01-11 [email protected] Roll Flutter from 4b23b81 to 864d4f5 (50 revisions) (flutter/packages#8408) 2025-01-10 49699333+dependabot[bot]@users.noreply.github.com [dependabot]: Bump org.json:json from 20240303 to 20250107 in /packages/in_app_purchase/in_app_purchase_android/android (flutter/packages#8413) 2025-01-10 49699333+dependabot[bot]@users.noreply.github.com [dependabot]: Bump org.json:json from 20241224 to 20250107 in /packages/in_app_purchase/in_app_purchase/example/android/app (flutter/packages#8410) 2025-01-10 49699333+dependabot[bot]@users.noreply.github.com [dependabot]: Bump io.mockk:mockk from 1.13.13 to 1.13.14 in /packages/pigeon/platform_tests/test_plugin/android (flutter/packages#8357) 2025-01-10 [email protected] Fix dependabot test-dependencies group io.mockk regex (flutter/packages#8406) 2025-01-10 49699333+dependabot[bot]@users.noreply.github.com [shared_pref]: Bump androidx.datastore:datastore from 1.0.0 to 1.1.1 in /packages/shared_preferences/shared_preferences_android/android (flutter/packages#7306) 2025-01-10 [email protected] [url_launcher_windows] Correct logging url (flutter/packages#8107) 2025-01-10 49699333+dependabot[bot]@users.noreply.github.com [dependabot]: Bump io.mockk:mockk from 1.13.13 to 1.13.14 in /packages/shared_preferences/shared_preferences_android/android (flutter/packages#8358) 2025-01-10 49699333+dependabot[bot]@users.noreply.github.com [dependabot]: Bump the androidx group across 3 directories with 1 update (flutter/packages#8329) 2025-01-10 49699333+dependabot[bot]@users.noreply.github.com [dependabot]: Bump org.json:json from 20240303 to 20241224 in /packages/in_app_purchase/in_app_purchase_android/example/android/app (flutter/packages#8372) 2025-01-10 [email protected] [url_launcher][web] Better support for semantics in the Link widget (flutter/packages#6711) 2025-01-10 [email protected] [camera]: Activate leak testing for sub packages (flutter/packages#8353) 2025-01-09 [email protected] [camera_android_camerax] Remove logic used to previously correct preview rotation (flutter/packages#8256) 2025-01-09 [email protected] [go_router] Rephrases readme to better describe the current status (flutter/packages#8403) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-packages-flutter-autoroll Please CC [email protected] on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
…er#161515) flutter/packages@6554751...3c3bc68 2025-01-11 49699333+dependabot[bot]@users.noreply.github.com [dependabot]: Bump the test-dependencies group across 2 directories with 1 update (flutter/packages#8412) 2025-01-11 49699333+dependabot[bot]@users.noreply.github.com [dependabot]: Bump org.json:json from 20241224 to 20250107 in /packages/in_app_purchase/in_app_purchase_android/example/android/app (flutter/packages#8411) 2025-01-11 [email protected] Roll Flutter from 4b23b81 to 864d4f5 (50 revisions) (flutter/packages#8408) 2025-01-10 49699333+dependabot[bot]@users.noreply.github.com [dependabot]: Bump org.json:json from 20240303 to 20250107 in /packages/in_app_purchase/in_app_purchase_android/android (flutter/packages#8413) 2025-01-10 49699333+dependabot[bot]@users.noreply.github.com [dependabot]: Bump org.json:json from 20241224 to 20250107 in /packages/in_app_purchase/in_app_purchase/example/android/app (flutter/packages#8410) 2025-01-10 49699333+dependabot[bot]@users.noreply.github.com [dependabot]: Bump io.mockk:mockk from 1.13.13 to 1.13.14 in /packages/pigeon/platform_tests/test_plugin/android (flutter/packages#8357) 2025-01-10 [email protected] Fix dependabot test-dependencies group io.mockk regex (flutter/packages#8406) 2025-01-10 49699333+dependabot[bot]@users.noreply.github.com [shared_pref]: Bump androidx.datastore:datastore from 1.0.0 to 1.1.1 in /packages/shared_preferences/shared_preferences_android/android (flutter/packages#7306) 2025-01-10 [email protected] [url_launcher_windows] Correct logging url (flutter/packages#8107) 2025-01-10 49699333+dependabot[bot]@users.noreply.github.com [dependabot]: Bump io.mockk:mockk from 1.13.13 to 1.13.14 in /packages/shared_preferences/shared_preferences_android/android (flutter/packages#8358) 2025-01-10 49699333+dependabot[bot]@users.noreply.github.com [dependabot]: Bump the androidx group across 3 directories with 1 update (flutter/packages#8329) 2025-01-10 49699333+dependabot[bot]@users.noreply.github.com [dependabot]: Bump org.json:json from 20240303 to 20241224 in /packages/in_app_purchase/in_app_purchase_android/example/android/app (flutter/packages#8372) 2025-01-10 [email protected] [url_launcher][web] Better support for semantics in the Link widget (flutter/packages#6711) 2025-01-10 [email protected] [camera]: Activate leak testing for sub packages (flutter/packages#8353) 2025-01-09 [email protected] [camera_android_camerax] Remove logic used to previously correct preview rotation (flutter/packages#8256) 2025-01-09 [email protected] [go_router] Rephrases readme to better describe the current status (flutter/packages#8403) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-packages-flutter-autoroll Please CC [email protected] on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
This CL fixes the URL being logged to be unescaped one if applicable instead of the original input URL.
Fixes #159009
Pre-launch Checklist
dart format
.)[shared_preferences]
pubspec.yaml
with an appropriate new version according to the pub versioning philosophy, or this PR is exempt from version changes.CHANGELOG.md
to add a description of the change, following repository CHANGELOG style, or this PR is exempt from CHANGELOG changes.///
).If you need help, consider asking for advice on the #hackers-new channel on Discord.