Enhance Image Transformation: Aspect Ratio Transition, Rotation Fixes, and Crop Rect Improvements #714
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
1. expose autoCenter method which is extracted from _startTimer() 2. add _lazy property managing to scale the image when needed
BUG: 1. when image is rotated with crop rect rotation, it only scale down image when needed, but will not scale up image to fit the layout viewport. Moreover, the image will getting smaller and smaller over repeatitive rotation. 2. the crop rect will changed unexpected when user drag it out of the image boundary. SOLUTION: 1. Refine the scaleToFit method (previously, it only scale when the image oversize). 2. redesign updateCropRect method.
1. it can rotate the crop rect to 270 degree (rotate to left) 2. add transition on updateCropAspectRatio 3. improve widget compatibility: widget will always reset configuration and actions when parent widget call setState(), it violated flutter widget design pattern and makes widget design and management become more complicated. Thus, deprecate the force reset code.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add Aspect Ratio Transition
• Introduced a smooth transition effect when changing the aspect ratio of the image.
https://github.com/user-attachments/assets/5e72eca7-006c-48ac-a04d-4a6d2458c99a
Fix Rotation Bug
• Resolved an issue where the image size would gradually shrink with consecutive rotations.
Correct Scaling on Rotation
• Ensured proper scaling is applied to the image when rotating, maintaining consistent dimensions.
Improve Rotation with Crop Rect
• Enhanced the rotation behavior within the cropping rectangle, addressing edge cases for 90° and 270° rotations.
https://github.com/user-attachments/assets/2562e9ba-e9d8-481d-b257-c59d58fe49ef
Resolve Issues [Bug report] SetState will Reset ExtendedImage and clear the Crop State #712 and [Bug report] Crop Area Changed Unexpectedly #713
• Fixed bugs, ensuring improved functionality and reliability.