🐛 Fix PMProgressHandler not getting notified when failed (#1099)

fluttercandies · Mar 7, 2024 · b487b5d · b487b5d
1 parent dfb1330
commit b487b5d
Show file tree

Hide file tree

Showing 2 changed files with 5 additions and 3 deletions.
diff --git a/CHANGELOG.md b/CHANGELOG.md
@@ -11,6 +11,7 @@ To know more about breaking changes, see the [Migration Guide][].
 ### Fixes
 
 - Do not predicate subtypes images as adjusted on Darwin.
+- Fix `PMProgressHandler` not getting notified when failed on Darwin.
 
 ## 3.0.0
 

diff --git a/ios/Classes/core/PMManager.m b/ios/Classes/core/PMManager.m
@@ -525,7 +525,7 @@ - (void)fetchLivePhotosFile:(PHAsset *)asset handler:(NSObject <PMResultHandler>
         if (error) {
             NSLog(@"error = %@", error);
             [self notifyProgress:progressHandler progress:0 state:PMProgressStateFailed];
-            [handler reply:nil];
+            [handler replyError:[NSString stringWithFormat:@"%@", error]];
         } else {
             [handler reply:path];
             [self notifySuccess:progressHandler];
@@ -566,7 +566,7 @@ - (void)fetchOriginVideoFile:(PHAsset *)asset handler:(NSObject <PMResultHandler
         if (error) {
             NSLog(@"error = %@", error);
             [self notifyProgress:progressHandler progress:0 state:PMProgressStateFailed];
-            [handler reply:nil];
+            [handler replyError:[NSString stringWithFormat:@"%@", error]];
         } else {
             [handler reply:path];
             [self notifySuccess:progressHandler];
@@ -778,7 +778,8 @@ - (void)fetchOriginImageFile:(PHAsset *)asset resultHandler:(NSObject <PMResultH
                              completionHandler:^(NSError *_Nullable error) {
         if (error) {
             NSLog(@"error = %@", error);
-            [handler reply:nil];
+            [self notifyProgress:progressHandler progress:0 state:PMProgressStateFailed];
+            [handler replyError:[NSString stringWithFormat:@"%@", error]];
         } else {
             [handler reply:path];
             [self notifySuccess:progressHandler];