Fix migration (#949)

fluttercommunity · Oct 21, 2024 · a7bc2ab · a7bc2ab
1 parent 81aaf55
commit a7bc2ab
Showing 1 changed file with 24 additions and 7 deletions.
diff --git a/android/src/main/kotlin/vn/hunghd/flutterdownloader/TaskDbHelper.kt b/android/src/main/kotlin/vn/hunghd/flutterdownloader/TaskDbHelper.kt
@@ -12,14 +12,31 @@ class TaskDbHelper private constructor(context: Context) :
     }
 
     override fun onUpgrade(db: SQLiteDatabase, oldVersion: Int, newVersion: Int) {
-        if (newVersion == 4) {
-            db.execSQL("ALTER TABLE ${TaskEntry.TABLE_NAME} ADD COLUMN ${TaskEntry.COLUMN_ALLOW_CELLULAR} TINYINT DEFAULT 1")
-        } else if (oldVersion == 2 && newVersion == 3) {
-            db.execSQL("ALTER TABLE " + TaskEntry.TABLE_NAME + " ADD COLUMN " + TaskEntry.COLUMN_SAVE_IN_PUBLIC_STORAGE + " TINYINT DEFAULT 0")
-        } else {
-            db.execSQL(SQL_DELETE_ENTRIES)
-            onCreate(db)
+        update1to2(db, oldVersion)
+        update2to3(db, oldVersion)
+        update3to4(db, oldVersion)
+    }
+
+    private fun update1to2(db: SQLiteDatabase, oldVersion: Int) {
+        if (oldVersion > 1) {
+            return
+        }
+        db.execSQL(SQL_DELETE_ENTRIES)
+        onCreate(db)
+    }
+
+    private fun update2to3(db: SQLiteDatabase, oldVersion: Int) {
+        if (oldVersion > 2) {
+            return
+        }
+        db.execSQL("ALTER TABLE " + TaskEntry.TABLE_NAME + " ADD COLUMN " + TaskEntry.COLUMN_SAVE_IN_PUBLIC_STORAGE + " TINYINT DEFAULT 0")
+    }
+
+    private fun update3to4(db: SQLiteDatabase, oldVersion: Int) {
+        if (oldVersion > 3) {
+            return
         }
+        db.execSQL("ALTER TABLE ${TaskEntry.TABLE_NAME} ADD COLUMN ${TaskEntry.COLUMN_ALLOW_CELLULAR} TINYINT DEFAULT 1")
     }
 
     override fun onDowngrade(db: SQLiteDatabase, oldVersion: Int, newVersion: Int) {