Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(share_plus): Add Swift Package Manager support #3169

Merged
merged 5 commits into from
Oct 16, 2024
Merged

feat(share_plus): Add Swift Package Manager support #3169

merged 5 commits into from
Oct 16, 2024

Conversation

charafau
Copy link
Contributor

ref: #3152

Another spm support

@charafau charafau mentioned this pull request Aug 11, 2024
Closed
@miquelbeltran miquelbeltran changed the title feat: [Share plus] Add Swift Package Manager support for Share plus feat(share_plus): Add Swift Package Manager support for Share plus Aug 12, 2024
miquelbeltran
miquelbeltran reviewed Aug 12, 2024
View reviewed changes
Copy link
Member

@miquelbeltran miquelbeltran left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, I still want to check on my devices before approval and merge

@miquelbeltran miquelbeltran added share_plus Feature, Enhancement, Bug Fixes for Share Plus Plugin and removed PR: needs review labels Aug 12, 2024
@vbuberen vbuberen changed the title feat(share_plus): Add Swift Package Manager support for Share plus feat(share_plus): Add Swift Package Manager support Aug 13, 2024
@vbuberen
Copy link
Collaborator

Edited the title and will do for the rest of PRs as there is already a scope in braces defined.

@charafau
Copy link
Contributor Author

Edited the title and will do for the rest of PRs as there is already a scope in braces defined.

Thank you 🙏 will try better next time

vbuberen
vbuberen approved these changes Oct 16, 2024
View reviewed changes
Copy link
Collaborator

@vbuberen vbuberen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Did a few small fixes, but overall everything works fine on iOS and MacOS.

Thanks for your contribution!

@vbuberen vbuberen merged commit b397022 into fluttercommunity:main Oct 16, 2024
17 of 20 checks passed
@loic-sharma loic-sharma mentioned this pull request Nov 13, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@miquelbeltran miquelbeltran miquelbeltran left review comments

@vbuberen vbuberen vbuberen approved these changes

Assignees
No one assigned
Labels
ios macos PR: needs manual testing share_plus Feature, Enhancement, Bug Fixes for Share Plus Plugin
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@charafau @vbuberen @miquelbeltran