-
Notifications
You must be signed in to change notification settings - Fork 187
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
controller: jitter requeue interval #1184
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This needs at least a merge and release of the pkg/runtime
pull requests before it can be merged.
In addition, it may be wise to make some small changes to the documentation to highlight that the .spec.interval
is now an approx setting.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Thanks @hiddeco 🎖️
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Tried it and works as advertised. Different requeue after values every reconciliation and no jitter with --interval-jitter-percentage=0
flag.
LGTM!
This adds a `--interval-jitter-percentage` flag to the controller to add a +/- percentage jitter to the interval defined in resources (defaults to 10%). Effectively, this results in a reconcilation every 4.5 - 5.5 minutes for a resource with an interval of 5 minutes. Main reason to add this change is to mitigate spikes in memory and CPU usage caused by many resources being configured with the same interval. Signed-off-by: Hidde Beydals <[email protected]>
Signed-off-by: Hidde Beydals <[email protected]>
Signed-off-by: Hidde Beydals <[email protected]>
This adds a
--interval-jitter-percentage
flag to the controller to add a +/- percentage jitter to the interval defined in resources (defaults to 10%).Effectively, this results in a reconcilation every 4.5 - 5.5 minutes for a resource with an interval of 5 minutes.
Main reason to add this change is to mitigate spikes in memory and CPU usage caused by many resources being configured with the same interval.
Supersedes #1057
xref: fluxcd/flux2#4120