Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix delete account bug #1118

Open
wants to merge 5 commits into
base: dev
Choose a base branch
from
Open

Fix delete account bug #1118

wants to merge 5 commits into from

Conversation

Nash0x7E2
Copy link
Contributor

  • Improve workflow around deleting a user account.
  • Create auth event for removing a user account
  • Better react to auth state changes in homepage

@Nash0x7E2
use a listener to react on auth states
441a96b 
Signed-off-by: Neevash Ramdial <[email protected]>
@Nash0x7E2
create event in bloc for deleting user
3fc1afe 
Signed-off-by: Neevash Ramdial <[email protected]>
@Nash0x7E2
call bloc event to control removing user
d4be465 
Signed-off-by: Neevash Ramdial <[email protected]>
@Nash0x7E2
untrack podfile lock
71a48d8 
Signed-off-by: Neevash Ramdial <[email protected]>
@Nash0x7E2
Podfile.lock
4e89a5a 
Signed-off-by: Neevash Ramdial <[email protected]>
@Nash0x7E2 Nash0x7E2 requested a review from tlalokyang October 17, 2020 02:00
@Nash0x7E2 Nash0x7E2 self-assigned this Oct 17, 2020
@Nash0x7E2 Nash0x7E2 added Auth Issues and bugs related to Cognito auth, login, sign up bug Something isn't working High Priority labels Oct 17, 2020
@Nash0x7E2
Copy link
Contributor Author

@sunyatax can we merge this?

@tlalokyang
Copy link
Member

I ran into issues while testing this - let me revisit and write them up

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tlalokyang tlalokyang Awaiting requested review from tlalokyang

Assignees

@Nash0x7E2 Nash0x7E2

Labels
Auth Issues and bugs related to Cognito auth, login, sign up bug Something isn't working High Priority
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Nash0x7E2 @tlalokyang