Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: improve workflows #186

Merged
merged 1 commit into from
Nov 15, 2024
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
39 changes: 34 additions & 5 deletions .github/workflows/rust.yml
Original file line number Diff line number Diff line change
Expand Up @@ -16,16 +16,24 @@ env:
RUSTFLAGS: "-Dwarnings"

jobs:
lint-fmt-test:
runs-on: ubuntu-latest
ci:
name: Check (${{ matrix.os }})
runs-on: ${{ matrix.os }}
strategy:
matrix:
os: [ubuntu-latest, windows-latest, macos-latest]

steps:
- uses: actions/checkout@v3
- uses: actions/checkout@v4

- name: Set up cargo cache
uses: Swatinem/rust-cache@v2

- name: Cargo check --all
run: cargo check
- name: Build
run: cargo build --all --all-features

- name: Cargo check
run: cargo check --all --all-features

- name: Rustfmt
run: cargo fmt --all -- --check
Expand All @@ -35,3 +43,24 @@ jobs:

- name: Test
run: cargo test --all --all-features

cargo-machete:
runs-on: ubuntu-latest
steps:
- name: Checkout
uses: actions/checkout@v4

- name: Machete
uses: bnjbvr/cargo-machete@main

typos:
# https://github.com/crate-ci/typos
# install and run locally: cargo install typos-cli && typos
name: typos
runs-on: ubuntu-latest
steps:
- name: Checkout Actions Repository
uses: actions/checkout@v4

- name: Check spelling of entire workspace
uses: crate-ci/typos@master
6 changes: 6 additions & 0 deletions .typos.toml
Original file line number Diff line number Diff line change
@@ -0,0 +1,6 @@
[default.extend-words]
# Don't correct german words
Ordner = "Ordner"
Elemente = "Elemente"
Alle = "Alle"
Ein = "Ein"
2 changes: 1 addition & 1 deletion src/config/keybindings.rs
Original file line number Diff line number Diff line change
Expand Up @@ -122,7 +122,7 @@ pub struct FileDialogKeyBindings {
}

impl FileDialogKeyBindings {
/// Checks wether any of the given keybindings is pressed.
/// Checks whether any of the given keybindings is pressed.
pub fn any_pressed(
ctx: &egui::Context,
keybindings: &Vec<KeyBinding>,
Expand Down
4 changes: 2 additions & 2 deletions src/data/directory_content.rs
Original file line number Diff line number Diff line change
Expand Up @@ -120,10 +120,10 @@ pub enum DirectoryContentState {
/// If we are currently waiting for the loading process on another thread.
/// The value is the timestamp when the loading process started.
Pending(SystemTime),
/// If loading the direcotry content finished since the last update call.
/// If loading the directory content finished since the last update call.
/// This is only returned once.
Finished,
/// If loading the directory content was successfull.
/// If loading the directory content was successful.
Success,
/// If there was an error loading the directory content.
/// The value contains the error message.
Expand Down
2 changes: 1 addition & 1 deletion src/file_dialog.rs
Original file line number Diff line number Diff line change
Expand Up @@ -2028,7 +2028,7 @@ impl FileDialog {
}
}

/// Updates the contents of the currenly open directory.
/// Updates the contents of the currently open directory.
/// TODO: Refactor
fn ui_update_central_panel_content(&mut self, ui: &mut egui::Ui) {
// Temporarily take ownership of the directory content.
Expand Down