Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

select dropped item #197

Merged
merged 2 commits into from
Nov 19, 2024
Merged

Conversation

hacknus
Copy link
Contributor

@hacknus hacknus commented Nov 19, 2024

This adresses #196.

However, in the current state the UI will not scroll to the selected (dropped) item. Even though self.scroll_to_selection = true;is set. Any ideas?

@fluxxcode
Copy link
Owner

Does the scrolling problem still exist?

@hacknus
Copy link
Contributor Author

hacknus commented Nov 19, 2024

yes, have not found a way around it yet..

@fluxxcode
Copy link
Owner

This doesn't seem to be a problem with this PR. Will merge this one and fix it on another branch.

Thanks for implementing!

@fluxxcode fluxxcode self-requested a review November 19, 2024 17:23
@fluxxcode fluxxcode merged commit e983dd0 into fluxxcode:develop Nov 19, 2024
5 checks passed
@fluxxcode
Copy link
Owner

Fixed the scroll to selection with #199 and was also able to remove new_file_dropped .

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants