rework: deprecate select methods #207
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Deprecated select methods and added new pick methods for more consistent naming.
This is the first PR to precisely name the public API. Overall, it's about correctly separating between currently selected and final picked items. For more information see: #171
The now deprecated methods will most likely be removed with
v0.9.0! In the version in which the deprecated methods are removed, theDialogModeandDialogStatevariants will also be renamed to Picked.Renamed the following methods:
select_directory->pick_directoryselect_file->pick_fileselect_multiple->pick_multipleselected->pickedtake_selected->take_pickedselected_multiple->picked_multipletake_selected_multiple->take_picked_multipleAlso renamed the
select_*examples.