WIP: Filesystem abstraction #227
Draft
+283
−148
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This already looks very good! Thanks for working on this. Yep, we have to use |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Here is a rough implementation of an abstraction over the file system and other OS functions (ex. user directories). There is a trait
FileSystem, a trait object of which can be passed toFileDialogas a way of overriding the default behavior. As a way of testing the API, I threw together a browser demo which allows one to upload a ZIP file and browse its contents: https://masterchef365.github.io/file-dialog-on-web/More to come, as I work out the rest of the implementation details. Mostly wanted to get some eyes on the API choices I've made here (is Arc the right interface?).