-
Notifications
You must be signed in to change notification settings - Fork 18
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Automatically edit filter string when user is typing #93
Automatically edit filter string when user is typing #93
Conversation
Simply if no widget is focused, we trigger the behavior
I cleaned up the code as much as I can, this is now ready for review. |
Thank you both for implementing this! Clearing the search buffer ( |
Whoops, I missed that. I added a commit that removes my redundant clear. |
…ange" This reverts commit 5c85255.
Ah crap, sorry, I missed that you wanted to keep my change. Lazy reading, lol. |
Fixes #89
Requirements from #89
There are also a few points about when we want to avoid the behavior:
Shiftso that we can implement Key bindings in the futureShift is probably desirable for capitalizing letters, so we want to allow editing while shift is being held down.
This seems to be working.
Extra behavior added
Credits
@aymey made the changes to satisfy the requirements of not activating the behavior. Sorry, your commits got lost because I did a rebase against the latest develop revision.