Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump GNOME runtime and LLVM version #1242

Merged
merged 6 commits into from
Oct 13, 2024
Merged

Bump GNOME runtime and LLVM version #1242

merged 6 commits into from
Oct 13, 2024

Conversation

RayJW
Copy link
Contributor

@RayJW RayJW commented Oct 1, 2024

This is just pure maintenance PR. This bumps the GNOME runtime to 47 and LLVM to 18. I tested both changes and everything works fine. I've used the changes for a bit doing my regular work with all kinds of different tools and tasks, everything seemed fine and maybe even a bit smoother (although that might easily be placebo). It probably still makes sense to test this for a bit before applying to the Flatpak, which is why I opened the PR here instead of on Flathub. Although I've never seen a runtime change break something if building worked fine.

@RayJW
Copy link
Contributor Author

RayJW commented Oct 1, 2024

I just realized I misread something somewhere. It seems like LLVM 18 is compatible with Rust 1.78 not 1.74, not sure where the mistake was on my side, but I'll revert that then to avoid any hidden consequences.

@RayJW
Copy link
Contributor Author

RayJW commented Oct 1, 2024

Seems like this might be more of a hassle than I initially thought. It seems like LLVM 17 won't get a 24.08 branch due to being EOL, so it won't be possible to bump GNOME to 47 either since that doesn't have a 23.08 branch. I'm not sure if upping the minimum Rust version is viable.

@flxzt
Copy link
Owner

flxzt commented Oct 1, 2024

Thank you!. Bumping Rust's MSCV MSRV should be fine in my opinion.

@RayJW
Copy link
Contributor Author

RayJW commented Oct 4, 2024

I used the cargo-msrv crate to check the compatibility and updated to the successful 1.79 version. Everything still compiles fine and seems to be working great so far :)

@RayJW
Copy link
Contributor Author

RayJW commented Oct 5, 2024

I bumped the MSRV to the latest Rust version (1.81) now since I don't see a reason to use a EOL version. I think that mostly makes sense for crates that are supposed to be used as dependencies.

@flxzt flxzt merged commit 919e28c into flxzt:main Oct 13, 2024
2 checks passed
@RayJW RayJW deleted the update_runtime branch October 13, 2024 10:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants