Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor: avoid using format! when String creation is unnecessary #1331

Merged
merged 1 commit into from
Dec 24, 2024
Merged

refactor: avoid using format! when String creation is unnecessary #1331

merged 1 commit into from
Dec 24, 2024

Conversation

Integral-Tech
Copy link
Contributor

@Integral-Tech Integral-Tech commented Dec 21, 2024 •
edited
Loading

  • When String creation is unnecessary, replace format!() with format_args!() to avoid overhead of heap allocation.

@flxzt
Copy link
Owner

flxzt commented Dec 24, 2024

looks good, thanks!

@flxzt flxzt merged commit d4ba8ed into flxzt:main Dec 24, 2024
2 checks passed
@Integral-Tech Integral-Tech deleted the refactor-format branch December 24, 2024 09:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Integral-Tech @flxzt