Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
WHAT AND WHY:
Disable PHP setting
allow_url_fopen
by default. Include a Dockerfile ENV variable called "PHP_ALLOW_URL_FOPEN" to turn this on ( 1 ) or off( 0 ).allow_url_fopen has some traces of evil in it, since: it can allow remote code execution. So by default, as suggested by a Fly community member in an email, we disable it for Fly Laravel apps. Of course, there maybe cases that a user may want this setting turned on, hence the ENV variable provided!
HOW
For Laravel apps set to be deployed to Fly.io, create a new
remote-file-access.conf
template that sets the value of allow_url_fopen based on the value of "PHP_ALLOW_URL_FOPEN" variable. Copy this over to the/etc/php/${PHP_VERSION}/fpm/pool.d
for it to be read.