fix: iOS memory leak when recreate canvas #42

flyskywhy · May 28, 2022 · a65d12a · a65d12a
1 parent 87befe4
commit a65d12a
Show file tree

Hide file tree

Showing 3 changed files with 11 additions and 0 deletions.
diff --git a/ios/BridgeModule/GCanvasModule.h b/ios/BridgeModule/GCanvasModule.h
@@ -55,6 +55,8 @@ typedef void (^GCanvasModuleCallback)(id result);
  */
 - (NSString*)enable:(NSDictionary *)args;
 
+- (void)disable:(NSString*)componentId;
+
 #pragma mark - Export Method of Context2D
 /**
  * Export JS method for reset GCanvas component while disappear

diff --git a/ios/BridgeModule/GCanvasModule.m b/ios/BridgeModule/GCanvasModule.m
@@ -182,6 +182,14 @@ - (NSString*)enable:(NSDictionary *)args{
     return @"true";
 }
 
+- (void)disable:(NSString*)componentId{
+    GCVLOG_METHOD(@"disable:, componentId=%@", componentId);
+
+    [[NSNotificationCenter defaultCenter] postNotificationName:kGCanvasDestroyNotification
+                                                        object:nil
+                                                      userInfo:@{@"instanceId":[self.deletage gcanvasModuleInstanceId]}];
+}
+
 #pragma mark - Need Export Context2D Method
 /**
  * Export JS method for reset GCanvas component while disappear

diff --git a/ios/RCTGCanvasModule.m b/ios/RCTGCanvasModule.m
@@ -78,6 +78,7 @@ - (dispatch_queue_t)methodQueue
 
 RCT_EXPORT_METHOD(disable:(NSString*) componentId)
 {
+    [self.gcanvasModule disable:componentId];
 }
 
 //preload image
-Original file line number
+Diff line change
@@ Expand Up / @@ -78,6 +78,7 @@ - (dispatch_queue_t)methodQueue @@
     RCT_EXPORT_METHOD(disable:(NSString*) componentId)
     {
+        [self.gcanvasModule disable:componentId];
     }
     //preload image
@@ Expand Down @@