Skip to content

Commit

Permalink
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Flyte-core chart prevent empty env:
Browse files Browse the repository at this point in the history
 - Some linters consider empty env: as invalid k8s YAML, because env is
   typically an [] when no values are set

   Prevent rendering the console env block without values

Signed-off-by: ddl-ebrown <ethan.brown@dominodatalab.com>
ddl-ebrown committed Jan 31, 2024
1 parent 63ba3fc commit 232c240
Showing 6 changed files with 2 additions and 5 deletions.
2 changes: 2 additions & 0 deletions charts/flyte-core/templates/console/deployment.yaml
Original file line number Diff line number Diff line change
@@ -33,7 +33,9 @@ spec:
name: flyte-console-config
ports:
- containerPort: 8080
{{- if or .Values.flyteconsole.ga.enabled .Values.flyteconsole.podEnv }}
env:
{{- end }}
{{- if .Values.flyteconsole.ga.enabled }}
- name: ENABLE_GA
value: "{{ .Values.flyteconsole.ga.enabled }}"
1 change: 0 additions & 1 deletion deployment/eks/flyte_aws_scheduler_helm_generated.yaml
Original file line number Diff line number Diff line change
@@ -1096,7 +1096,6 @@ spec:
name: flyte-console-config
ports:
- containerPort: 8080
env:
resources:
limits:
cpu: 250m
1 change: 0 additions & 1 deletion deployment/eks/flyte_helm_controlplane_generated.yaml
Original file line number Diff line number Diff line change
@@ -802,7 +802,6 @@ spec:
name: flyte-console-config
ports:
- containerPort: 8080
env:
resources:
limits:
cpu: 250m
1 change: 0 additions & 1 deletion deployment/eks/flyte_helm_generated.yaml
Original file line number Diff line number Diff line change
@@ -1127,7 +1127,6 @@ spec:
name: flyte-console-config
ports:
- containerPort: 8080
env:
resources:
limits:
cpu: 250m
1 change: 0 additions & 1 deletion deployment/gcp/flyte_helm_controlplane_generated.yaml
Original file line number Diff line number Diff line change
@@ -817,7 +817,6 @@ spec:
name: flyte-console-config
ports:
- containerPort: 8080
env:
resources:
limits:
cpu: 250m
1 change: 0 additions & 1 deletion deployment/gcp/flyte_helm_generated.yaml
Original file line number Diff line number Diff line change
@@ -1150,7 +1150,6 @@ spec:
name: flyte-console-config
ports:
- containerPort: 8080
env:
resources:
limits:
cpu: 250m

0 comments on commit 232c240

Please sign in to comment.