Skip to content

Commit

Permalink
ttl comparison should allow 23
Browse files Browse the repository at this point in the history
Signed-off-by: Daniel Rammer <[email protected]>
  • Loading branch information
hamersaw committed Jan 30, 2024
1 parent 460f0f1 commit 58cb643
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion flytepropeller/pkg/controller/garbage_collector.go
Original file line number Diff line number Diff line change
Expand Up @@ -169,7 +169,7 @@ func (g *GarbageCollector) StartGC(ctx context.Context) error {

func NewGarbageCollector(cfg *config.Config, scope promutils.Scope, clk clock.WithTicker, namespaceClient corev1.NamespaceInterface, wfClient v1alpha1.FlyteworkflowV1alpha1Interface) (*GarbageCollector, error) {
ttl := 23
if cfg.MaxTTLInHours < 23 {
if cfg.MaxTTLInHours <= 23 {
ttl = cfg.MaxTTLInHours
} else {
logger.Warningf(context.TODO(), "defaulting max ttl for workflows to 23 hours, since configured duration is larger than 23 [%d]", cfg.MaxTTLInHours)
Expand Down

0 comments on commit 58cb643

Please sign in to comment.